Possible copy by array test coverage gaps

Open
#4,575 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
testing

Research direction

Start by reviewing the existing tests under test/built-ins/Array/prototype/toSorted and the corresponding TypedArray directories, including their spec comments and file naming patterns. Add normal-use coverage for default and custom toSorted comparators and verify that TypedArray.prototype.toReversed produces reversed output. Done means the listed happy paths are explicitly asserted in the appropriate test files.

Written by the indexing model from the issue text.

Description

I'm leveraging these unit tests to verify some "copy by array" polyfill implementations.

The tests appear to focus more on corner cases and less so on actual normal expected usage.

Some specific gaps I noticed:

For other tests, the "happy path" is often not explicitly tested. Proper behavior is often verified while testing for different corner cases.


There seems to be a very specific format to the spec comments in the test files and the file naming convention--both of which I'm unfamiliar with--so I'm hesitant to offer to help fill these gaps.

If some guidance were provided on both these points, I'd be happy to help address these gaps.

Dominant language
JavaScript
Stars
2.9k
Forks
571
Avg merge
1d 22h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tc39/test262

All issues in tc39/test262

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.