Harness tests should run when harness source changes

Open
#4,201 0 comments 4 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript

Research direction

Start in package.json by reading the test:diff:* scripts, then inspect the harness/ and test/harness/*.js paths mentioned in the issue. Update the scripts so harness tests run when harness sources change, and verify the diff-test commands cover those cases.

Written by the indexing model from the issue text.

Description

#4197 notes that #4091 and #4187 broke some harness tests, which should have been surfaced sooner. I think we should update the package.json test:diff:… scripts to include all test/harness/*.js files whenever harness/ includes any changes.

Dominant language
JavaScript
Stars
2.9k
Forks
571
Avg merge
1d 22h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tc39/test262

All issues in tc39/test262

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.