Follow-up to Intl.DurationFormat #3912
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- testing
Research direction
Start by reading issue #3912 and the two named tests: test/intl402/DurationFormat/constructor-option-read-order.js and test/intl402/DurationFormat/prototype/resolvedOptions/return-keys-order-default.js. Run these tests before changing them, then update the coverage for property-read order and fractionalDigits construction; done means the expected orders are tested and the tests pass.
Written by the indexing model from the issue text.
Description
Address comments from #3912.
test/intl402/DurationFormat/constructor-option-read-order.js:localeMatcheris read beforenumberingSystembut isn't inresolvedOptions(). Probably better to use aProxythat pushes all Get operations to the array, rather than just the ones inresolvedOptions().test/intl402/DurationFormat/prototype/resolvedOptions/return-keys-order-default.js:fractionalSecondsis added last if notundefined. Consider testing the order again when constructing the object with e.g.new Intl.DurationFormat('en', { fractionalDigits: 0 }).
cc @FrankYFTang
- Dominant language
- JavaScript
- Stars
- 2.9k
- Forks
- 571
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tc39/test262
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
tc39/test262#5190 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
tc39/test262#5185 · 7 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
tc39/test262#5159 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tc39/test262#5133 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 Under an hour Newbie friendliness 82/100
Leonxlnx/taste-skill#216 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
all-contributors/cli#690 ·
Maintainers usually reply within 1 day