s390 symbols exported despite --without-s390
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 40/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- build-system, c
- Domain
- build-system
Research direction
The bug is that bd_s390_* symbols still reach the shared library when configure runs with --without-s390. Start in the configure option handling and the build files that decide which s390 sources get compiled and linked, then check whether the exported symbol list still includes them. Done means that building with --without-s390 on s390x produces a library whose dynamic symbol table (checked with nm -D) has no bd_s390_* entries.
Written by the indexing model from the issue text.
Description
Version: 3.2.0
I'm building libblockdev with the following configure parameters in Debian:
https://salsa.debian.org/utopia-team/libblockdev/-/blob/debian/sid/debian/rules?ref_type=heads#L19
which includes --without-s390
Still, it seems that on s390x, libblockdev exposes s390 specific symbols:
https://buildd.debian.org/status/fetch.php?pkg=libblockdev&arch=s390x&ver=3.2.0-1&stamp=1726233201&raw=0
dpkg-gensymbols: error: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libblockdev3/DEBIAN/symbols doesn't match completely debian/libblockdev3.symbols
--- debian/libblockdev3.symbols (libblockdev3_3.2.0-1_s390x)
+++ dpkg-gensymbolsSqholI 2024-09-13 13:13:09.720119877 +0000
@@ -527,6 +527,19 @@
bd_plugin_spec_get_type@Base 2.14
bd_plugin_spec_new@Base 3.1.0
bd_reinit@Base 2.14
+ bd_s390_dasd_format@Base 3.2.0-1
+ bd_s390_dasd_is_fba@Base 3.2.0-1
+ bd_s390_dasd_is_ldl@Base 3.2.0-1
+ bd_s390_dasd_needs_format@Base 3.2.0-1
+ bd_s390_dasd_online@Base 3.2.0-1
+ bd_s390_error_quark@Base 3.2.0-1
+ bd_s390_is_tech_avail@Base 3.2.0-1
+ bd_s390_sanitize_dev_input@Base 3.2.0-1
+ bd_s390_zfcp_offline@Base 3.2.0-1
+ bd_s390_zfcp_online@Base 3.2.0-1
+ bd_s390_zfcp_sanitize_lun_input@Base 3.2.0-1
+ bd_s390_zfcp_sanitize_wwpn_input@Base 3.2.0-1
+ bd_s390_zfcp_scsi_offline@Base 3.2.0-1
bd_smart_ata_attribute_copy@Base 3.2.0
bd_smart_ata_attribute_free@Base 3.2.0
bd_smart_ata_attribute_get_type@Base 3.2.0
dh_makeshlibs: error: failing due to earlier errors
Is it really intentional, that libblockdev exposes those symbols (on s390x) even when it is built using --without-s390?
- Dominant language
- C
- Stars
- 137
- Forks
- 64
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from storaged-project/libblockdev
-
fails to build with libnvme3 (nvme-cli 3.0)Possibly taken @tbzatek claimed this 38 days ago. Open
storaged-project/libblockdev#1211 · 4 comments · 1 assignee ·
-
RFE
Difficulty 3/5 1-2 days Newbie friendliness 35/100
storaged-project/libblockdev#1093 · 3 comments ·
-
Difficulty 4/5 Over a week Newbie friendliness 18/100
storaged-project/libblockdev#1067 ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 12/100
storaged-project/libblockdev#977 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 8/100
storaged-project/libblockdev#966 · 3 comments ·
All issues in storaged-project/libblockdev
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MerginMaps/geodiff#272 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
open-quantum-safe/liboqs#2644 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
espressif/esp-adf-libs#89 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days