Siblings of #4108: leading \b before dash-flag alternation members in language rules

Open
#7,863 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
54/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
tooling

Research direction

Read the listed language rule locations in agc_assembly.py, assembly.py, csharp.py, go.py, javascript.py, lua.py, ruby.py, swift.py, and dart.py, along with the related changes in PR #7862 and the completed Java, Kotlin, and Scala items. Check each candidate against its language’s intended matching behavior, then golden-check the changes per language. Done means the unintended word-boundary failures are fixed and the -DskipTests Dockerfile case is covered; the issue notes that some matches may be intentional.

Written by the indexing model from the issue text.

Description

core-engine scope:infra testing

Siblings of #4108 (PR #7862 fixed dockerfile.py). Class: a leading \b(?:...) before an alternation member starting with a non-word char (-Xmx, --flag) can never match after whitespace. Heuristic scan; each needs its own read, some may be intentional. Fix with (?<![\w-]), golden-check per language.

  • agc_assembly.py:245
  • assembly.py:383
  • csharp.py:600
  • go.py:550
  • java.py:556 (#7864)
  • javascript.py:378
  • kotlin.py:202 (#7864)
  • lua.py:289
  • ruby.py:308
  • scala.py:392 (#7864)
  • swift.py:475
  • dart.py:170, dart.py:386
  • dockerfile skipTests misses -DskipTests
Dominant language
Python
Stars
57
Forks
11
Avg merge
1h 35m
Merged PRs (30d)
975

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from squid-protocol/gitgalaxy

All issues in squid-protocol/gitgalaxy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.