Support multiple client-registration-id configurations
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- api, authentication, backend
Research direction
Locate the existing handling for spring.cloud.openfeign.oauth2.client-registration-id and the OAuth2AccessTokenInterceptor entry point. Add support for the proposed client-registration-ids map keyed by Feign client name, while retaining the existing property as the default, and verify both configuration paths.
Written by the indexing model from the issue text.
Description
Multiple registration ids
In some environments it is required to support targeting multiple Oauth2 servers. The current solution for non-load-balanced feign clients only provide a single client-registration-id with the property spring.cloud.openfeign.oauth2.client-registration-id, so this is not possible.
Proposed solution
Add a new configuration: spring.cloud.openfeign.oauth2.client-registration-ids which should be a Map<String, String> mapping feign clients by name to a registration id. The default should still be spring.cloud.openfeign.oauth2.client-registration-id so there are no backward compatibility issues.
Other alternatives considered
- Using load-balanced clients
- Downsides
- A new
spring.security.oauth2.client.registrationandspring.security.oauth2.client.providermust be provided per each client if the clients use discrete names - Using the same name makes it difficult to do ad-hoc switching of hostname for a single client
- The logs do not show the actual URL called, which makes debugging much more difficult
- A new
- Downsides
- Make a local custom
OAuth2AccessTokenInterceptor
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 836
- Avg merge
- 19h 49m
- Merged PRs (30d)
- 24
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from spring-cloud/spring-cloud-openfeign
-
question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
spring-cloud/spring-cloud-openfeign#1392 · 1 comment ·
Maintainers usually reply within 1 day
-
FeignClientsConfiguration$MicrometerConfiguration.class cannot be opened because it does not existOpenfeedback-provided
Difficulty 4/5 3-5 days Newbie friendliness 35/100
spring-cloud/spring-cloud-openfeign#1379 · 5 comments ·
Maintainers usually reply within 1 day
-
waiting-for-triage
Difficulty 3/5 1-2 days Newbie friendliness 57/100
spring-cloud/spring-cloud-openfeign#1344 · 2 comments ·
Maintainers usually reply within 1 day
-
waiting-for-triage
Difficulty 3/5 1-2 days Newbie friendliness 45/100
spring-cloud/spring-cloud-openfeign#1340 · 1 comment ·
Maintainers usually reply within 1 day
-
dependencies
Difficulty 3/5 1-2 days Newbie friendliness 55/100
spring-cloud/spring-cloud-openfeign#1334 · 11 comments · 4 reactions ·
Maintainers usually reply within 1 day
All issues in spring-cloud/spring-cloud-openfeign
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
apache/rocketmq-dashboard#6896 ·
Maintainers usually reply within 3 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OpenIntegrationEngine/engine#496 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
SasanLabs/VulnerableApp#836 ·
Maintainers usually reply within 1 day
-
enhancement frontend
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Albertinesilva/backend-engineering-journey-java-springboot#46 ·
-
Snyk: vulnerabilities in jackson-databind 2.21.5Possibly taken @harrywu23 claimed this today. Openbug
Difficulty 1/5 1-3 hours Newbie friendliness 80/100
SOFTENG-310-Group-4/Project-A1-310-Group-4#115 ·
Maintainers usually reply within 1 day