Trailing slash was added while posting to service context path
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Reproduce the request using the Service A Feign client and Service B controller shown in the issue, then trace how @FeignClient(path = "member") and @PostMapping combine into the request URL. Done when the generated POST target omits the trailing slash and a regression test covers this context-path case.
Written by the indexing model from the issue text.
Description
There are two services, service A and service B.
in Service B, its context path is member and there is a controller defined as follow
@Contoller
public MemberController {
@PostMapping
public Member saveMember(Member member){
}
}
and in Service A, a Feign client is defined to call this endpoint
@FeignClient(name = "service-b", path = "member")
public MemberFeignClient {
@PostMapping
public Member saveMember(Member member);
}
While executing the code, feign client print log with location calling to http://service-b/member/, which a trailing slash was added. I tried to add config from code or autoconfig to remove it but it was still added.
As Spring is no longer support trailing slash, it threw error as the path not found.
Version:
Spring Cloud OpenFeign: 5.0.1
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 836
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 25
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from spring-cloud/spring-cloud-openfeign
-
question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
spring-cloud/spring-cloud-openfeign#1392 · 1 comment ·
Maintainers usually reply within 1 day
-
FeignClientsConfiguration$MicrometerConfiguration.class cannot be opened because it does not existOpenfeedback-provided
Difficulty 4/5 3-5 days Newbie friendliness 35/100
spring-cloud/spring-cloud-openfeign#1379 · 5 comments ·
Maintainers usually reply within 1 day
-
waiting-for-triage
Difficulty 3/5 1-2 days Newbie friendliness 57/100
spring-cloud/spring-cloud-openfeign#1344 · 2 comments ·
Maintainers usually reply within 1 day
-
waiting-for-triage
Difficulty 4/5 3-5 days Newbie friendliness 45/100
spring-cloud/spring-cloud-openfeign#1343 ·
Maintainers usually reply within 1 day
-
dependencies
Difficulty 3/5 1-2 days Newbie friendliness 55/100
spring-cloud/spring-cloud-openfeign#1334 · 11 comments · 4 reactions ·
Maintainers usually reply within 1 day
All issues in spring-cloud/spring-cloud-openfeign
Similar issues
-
`timer` rule rejects dates the engine acceptsPossibly taken @MFA-G claimed this today. Openbug ready
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
camunda/bpmnlint-plugin-camunda-compat#281 · 3 comments ·
Maintainers usually reply within 1 day
-
status: waiting-for-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
AOT compilation fails for derived delete queries returning SetPossibly taken @ryujungkyun claimed this today. Openstatus: waiting-for-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
spring-projects/spring-data-jpa#4387 ·
Maintainers usually reply within 3 days