Soccer recipes: the shot filter drops penalties; note the StatsBomb own goal
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- data-visualization
Research direction
The shot filter is the (?i)shot|goal pattern in cookbook sections §9 and §10 of examples/notebooks/cookbooks/surfaces-and-shot-charts.ipynb, and the same filter appears in vignettes/articles/soccer-viz.Rmd in sdvplotR. Start by reading those filter cells and running them on event 740970 to confirm the current counts. Done means penalty plays are kept by the filter in both files and a one-line note explains why the StatsBomb map shows 5 goals for the 4-2 final.
Written by the indexing model from the issue text.
Description
From the soccer/FIBA program's final review. Both soccer shot-map recipes (cookbook §9/§10 in examples/notebooks/cookbooks/surfaces-and-shot-charts.ipynb; the sdvplotR article mirrors them) filter ESPN plays on (?i)shot|goal, which drops Penalty - Scored / Penalty - Missed — harmless for event 740970 (no penalties) but wrong for any match that has them. Also add a one-line note that the StatsBomb map marks 5 Shot goals for a 4-2 final because the own goal is a separate event type. Same fix for sdvplotR's vignettes/articles/soccer-viz.Rmd.
- Dominant language
- Python
- Stars
- 1
- Forks
- 0
- Avg merge
- 3h 26m
- Merged PRs (30d)
- 129
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sportsdataverse/sdvplot
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
sportsdataverse/sdvplot#99 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
sportsdataverse/sdvplot#100 ·
Maintainers usually reply within 1 day
-
live-tests:drift
Difficulty 4/5 3-5 days Newbie friendliness 45/100
sportsdataverse/sdvplot#118 · 1 comment ·
Maintainers usually reply within 1 day
All issues in sportsdataverse/sdvplot
Similar issues
-
area/config comp/tools P2 platform/telegram type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NousResearch/hermes-agent#145412 ·
Maintainers usually reply within 1 day
-
[oblt-aw][autodoc] Update docs for security org scaffolding and Docs AI menu permission changesPossibly taken @github-actions claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Community project: hosted MOSS-Image studio with a visual JSON layout builder (no ComfyUI needed)Open
Difficulty 1/5 1-3 hours Newbie friendliness 65/100
OpenMOSS/MOSS-Image#27 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
deepspeedai/DeepSpeed#8925 · 1 comment ·
Maintainers usually reply within 3 days
-
external integration integration-submission
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/docs#7077 ·
Maintainers usually reply within 1 day