surface(): document the InputError for a team on a no-team surface; pitch_updates=None
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- data-visualization, documentation
Research direction
Start in src/sdvplot/_surface.py, in surface(): the Raises block and the merge {**SOCCER_PITCH, **sportypy_kwargs.get("pitch_updates", {})}. Reproduce with surface("soccer", pitch_updates=None) to see the TypeError. Done when None falls back to the defaults like an absent key, and the Raises block lists the InputError for a team on a league in NO_TEAMS ("fiba").
Written by the indexing model from the issue text.
Description
From the soccer/FIBA program's final review. (1) surface()'s Raises block (src/sdvplot/_surface.py) omits the InputError raised for a team on a league in NO_TEAMS ("fiba"). (2) surface("soccer", pitch_updates=None) raises TypeError: 'NoneType' object is not a mapping at the {**SOCCER_PITCH, **sportypy_kwargs.get("pitch_updates", {})} merge; R's pitch_updates = NULL gives the 105 x 68 defaults. Treat None like absent.
- Dominant language
- Python
- Stars
- 1
- Forks
- 0
- Avg merge
- 3h 26m
- Merged PRs (30d)
- 129
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sportsdataverse/sdvplot
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
sportsdataverse/sdvplot#101 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
sportsdataverse/sdvplot#99 ·
Maintainers usually reply within 1 day
-
live-tests:drift
Difficulty 4/5 3-5 days Newbie friendliness 45/100
sportsdataverse/sdvplot#118 · 1 comment ·
Maintainers usually reply within 1 day
All issues in sportsdataverse/sdvplot
Similar issues
-
The changelog workflow excludes otelbot but not dependabot, so every Dependabot pull request fails the changelog checkPossibly taken @ocelotl claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 82/100
open-telemetry/opentelemetry-python#5825 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cuga-project/cuga-agent#1020 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
microsoft/playwright#43640 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
stac-utils/stac-fastapi-elasticsearch-opensearch#965 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day