tui/audit: delete-all and export-all silently ignore the active filter and a 1000-row cap
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 57/100
Research direction
Start with tui/audit/audit_keys.go at the delete-all and export-all actions, then read audit_keys_test.go around line 449 and how the audit view stores its active filter. Reproduce both cases with a filtered subset and more than 1000 matching rows. Done means delete-all respects the displayed subset, export-all includes all matches or clearly warns about a cap, and a test covers filtered deletion.
Written by the indexing model from the issue text.
Description
Problem
Three related issues in packages/tui/audit/audit_keys.go:
:205— the "delete all" action operates on the full unfiltered log set rather than respecting whatever filter the user currently has applied in the view, so a user who filtered the view down to a subset and triggers "delete all" ends up deleting entries outside that filtered view too.:233— "export all" silently caps the exported set at 1000 rows with no indication to the user that the export was truncated, so a log with more than 1000 matching entries produces an incomplete export the user may not realize is incomplete.audit_keys_test.go:449— there is no test covering the filtered "delete all" case, so this bundling/scoping bug would not be caught by the test suite.
Impact
A user applying a filter before "delete all" can lose entries they did not intend to delete, since the action silently operates on the full log rather than the filtered subset shown on screen. A user exporting more than 1000 matching entries gets a silently truncated export file and may believe it contains the complete filtered dataset when it does not.
Repro
- Apply a filter in the audit view (e.g. by agent or by DLP match) that narrows the displayed entries to a subset, then trigger "delete all"; observe entries outside the filtered subset are also deleted.
- Apply a filter (or none) that matches more than 1000 entries, trigger "export all", and observe the resulting export file contains only 1000 rows with no warning that more entries existed.
Suggested fix
Make "delete all" operate only on the currently filtered/displayed entry set, not the full underlying log, when a filter is active. Remove (or clearly surface) the 1000-row export cap: either export the full filtered set regardless of size, or if a cap remains necessary for resource reasons, show an explicit warning/prompt when the matching set exceeds it. Add a test covering "delete all" with an active filter to lock in the corrected scoping behavior.
- Dominant language
- Go
- Stars
- 157
- Forks
- 19
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 96
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from solongate/agent-security
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 91/100
solongate/agent-security#226 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solongate/agent-security#223 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
solongate/agent-security#220 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
solongate/agent-security#215 ·
Maintainers usually reply within 1 day
-
hooks: baked guard-binary path isn't quote-escaped, can produce invalid JS for the OpenCode pluginOpenbug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solongate/agent-security#207 ·
Maintainers usually reply within 1 day
All issues in solongate/agent-security
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
lognorman20/monaco#7428 ·
-
docs(prompts): IF BLOCKED workflow-scope branch says to comment on the issue on jira/local trackersOpenagent-butler-finding bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
jordansmall/spindrift#6238 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
microcks/microcks-cli#608 · 1 comment ·
Maintainers usually reply within 1 day
-
bug from-studio
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
esengine/DeepSeek-Reasonix#14868 ·
Maintainers usually reply within 1 day