app: cliSubcommands omits update, bypasses human-terminal gate
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 91/100
Research direction
Read packages/app/main.go, especially the cliSubcommands map near line 26 and the table() command registrations near line 159. Check how isHumanCLI uses the map and compare the gating of update with repair. Add update to the map; done when solongate update is subject to assertHumanTerminal like the other listed commands.
Written by the indexing model from the issue text.
Description
Problem
cliSubcommands in packages/app/main.go:26 lists the subcommands that must run from a human terminal, but omits "update", even though table() at line 159 registers "update" in the same command table alongside other gated commands like "repair".
cliSubcommands = map[string]bool{
"init": true, "status": true, "repair": true, ...
}
"update" is missing from this map.
Impact
isHumanCLI := len(args) == 0 || cliSubcommands[sub] evaluates false for sub == "update", so assertHumanTerminal never runs for solongate update. Every other sensitive command in the table (repair, etc.) is blocked from running non-interactively, for example from a script, a CI job, or a confined agent shelling out, but update is not, letting it run and replace the installed binary outside the human-terminal guarantee the rest of the table enforces.
Suggested fix
Add "update": true to cliSubcommands.
- Dominant language
- Go
- Stars
- 157
- Forks
- 19
- Avg merge
- 4h 28m
- Merged PRs (30d)
- 88
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from solongate/agent-security
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
solongate/agent-security#227 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
solongate/agent-security#225 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
solongate/agent-security#224 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solongate/agent-security#223 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
solongate/agent-security#222 ·
Maintainers usually reply within 1 day
All issues in solongate/agent-security
Similar issues
-
VLAgent `spec.k8sCollector.includePodLabels: false` has no effectPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
VictoriaMetrics/operator#2772 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Gaurav-Gosain/tuios#1316 ·
Maintainers usually reply within 1 day
-
needs: investigation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:auth documentation priority:low
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Mend: dependency security vulnerability
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
kube-tarian/sigrun#203 ·