add_key() and string measurements don't check Lente column sizes
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start by reading docs/source/_traceability.rst for the documented column limits, then locate ResultBaseKeysV1.add_key() and measurement() in the scripts. Check how existing errors are logged and how RECORD_RESULT_INTERNAL_ERROR is returned. Done means overlong keys and string values are caught on the station before Lente inserts the record.
Written by the indexing model from the issue text.
Description
ResultBaseKeysV1.add_key() stores "<name>:<value>" with no length check, but Lente's record.key0-key4 columns are String(64). measurement() checks the name (128) but not a string value, and measurement.value is String(128).
A longer key or string value passes on Prism and only fails when Lente inserts the record, so the result goes to quarantine.
Suggested fix: check the length in add_key() (return False and log) and in measurement() for str values (RECORD_RESULT_INTERNAL_ERROR), so the problem shows on the station during development. The limits are now documented in docs/source/_traceability.rst.
- Dominant language
- C++
- Stars
- 4
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sistemicorp/scripts
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
sistemicorp/scripts#60 ·
-
bug documentation
Difficulty 4/5 3-5 days Newbie friendliness 38/100
sistemicorp/scripts#59 ·
-
Add P1150 Hardware DriverMay be free again @sistemicorp claimed this 186 days ago, and no pull request is open. Openenhancement
sistemicorp/scripts#52 · 1 assignee ·
-
[BOND] Changes for rev3May be free again @sistemicorp claimed this 375 days ago, and no pull request is open. Openenhancement
sistemicorp/scripts#26 · 1 assignee ·
All issues in sistemicorp/scripts
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
k2-fsa/sherpa-onnx#4100 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Mod: Part Design Topic: User Interface
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
A-tools P-medium S-ready-to-start task
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Vim/NeoVim pluginOpen
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day