Convert \SAML2\Configuration\IdentityProvider to interface
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- php
- Domain
- authentication
Research direction
Start by reviewing the existing \SAML2\Configuration\IdentityProvider and \SAML2\Configuration\ServiceProvider classes, then trace how \SAML2\Assertion\ProcessorBuilder uses them. Clarify the interface contract and compatibility impact before changing the classes; done means custom non-array-based provider configurations can be used to validate assertions.
Written by the indexing model from the issue text.
Description
I'd like to integrate this library into my application. However, \SAML2\Configuration\IdentityProvider and \SAML2\Configuration\ServiceProvider are classes.
Is there any interest in converting them to pure interfaces such that one can implement completely custom service/identity provider configuration classes (not based on arrays)? If so, should I submit a pull-request and rename the existing class to QueryableIdentityProvider?
Intent: We'd like to use \SAML2\Assertion\ProcessorBuilder to validate our assertions.
- Dominant language
- PHP
- Stars
- 306
- Forks
- 138
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from simplesamlphp/saml2
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
simplesamlphp/saml2#408 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
simplesamlphp/saml2#397 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
simplesamlphp/saml2#360 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
simplesamlphp/saml2#345 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
simplesamlphp/saml2#309 · 18 comments ·
All issues in simplesamlphp/saml2
Similar issues
-
Solved site promotion gate fails on runner PHP patch drift (expects 8.2.33, runner installs 8.2.34) Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Automattic/blocks-engine#2161 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/static-site-importer#1824 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100