Harden response/assertion validation with #[\NoDiscard] attribute

Open
#397 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
php
Domain
backend

Research direction

Start with the PHP 8.5 #[\NoDiscard] documentation linked in the issue, then locate the library's response and assertion validation entry points. Determine which relevant results should be protected from being discarded and verify the attribute is applied without changing validation behavior.

Written by the indexing model from the issue text.

Description

https://www.php.net/releases/8.5/en.php#no-discard-attribute

Dominant language
PHP
Stars
306
Forks
138
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simplesamlphp/saml2

All issues in simplesamlphp/saml2

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.