Make NameID emailAddress value assertion optional
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- php
- Domain
- authentication
Research direction
Start by inspecting the NameID implementation referenced in the issue and locate the assertion that requires the Subject NameID to be an email address. Check nearby tests and configuration patterns; done means callers can disable this assertion for non-email NameIDs while the current validation remains the default.
Written by the indexing model from the issue text.
Description
We just updated from v4 to v6 and some authentication failed. After digging around we found that the value of the Subject NameID isn't a valid email address in some cases. This isn't something we can ask the IdP to change.
From what we can see from other SAML2 libraries, it seems to be a common practice to be able to disable some assertions like this one.
- Dominant language
- PHP
- Stars
- 306
- Forks
- 138
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from simplesamlphp/saml2
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
simplesamlphp/saml2#397 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
simplesamlphp/saml2#360 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
simplesamlphp/saml2#345 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
simplesamlphp/saml2#309 · 18 comments ·
-
Why doesn't the package support multiple NameFormat attributes for the <saml:Attribute> element? Open
Difficulty 4/5 3-5 days Newbie friendliness 42/100
simplesamlphp/saml2#286 · 3 comments ·
All issues in simplesamlphp/saml2
Similar issues
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
phpstan/phpstan-doctrine#794 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Automattic/static-site-importer#1767 ·