Language service follow-ups: popup after host move, API gaps, stale hover, test data, fix formatting

Open
  • Is something wrong?
#128 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
developer-experience

Research direction

Start by reading PR #127's language-service and environment-box review, then trace the completion popup, ITextLanguageService, hover updates, EnvironmentServiceTests, and ReplaceLanguage. The issue lists several independent fixes across UI behavior, API design, test data, and formatting; completion means each listed problem has a defined fix and corresponding behavior or test.

Written by the indexing model from the issue text.

Description

From the PR #127 (language service / environment box) review:

  • The completion popup stays at its old screen position after a WinForms form hosting the field is moved.
  • ITextLanguageService gaps for a second consumer (Markdown source mode, VS Code adapter): isIncomplete / filterText / additionalTextEdits on completion, more than one fix per diagnostic, a document version or id, async CanInsert, and a Constrain hook for constrained editing.
  • A language-service hover tooltip goes stale after an edit while the pointer stays still.
  • EnvironmentServiceTests reuses liblcm's test-data list verbatim and in order (including a duplicate); write our own cases (clean room).
  • ReplaceLanguage takes the run after the insertion point, where typing takes the run before it, and a multi-edit fix flattens formatting and embedded objects.
Dominant language
C#
Stars
0
Forks
0
Avg merge
1h 43m
Merged PRs (30d)
43

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sillsdev/SIL.TextEditing

All issues in sillsdev/SIL.TextEditing

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.