Open a journal day by clicking its title
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #81 by @shovon — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start in app/src/renderer/project/PageView/PageView.tsx, where the title is rendered three ways: as a wikilink anchor under Linked references and on zoomed pages, and as a plain h2 in the journal. Read app/src/renderer/project/ProjectView.tsx to see how a a.wikilink[href] click already calls pages.go({ page }), and pass a flag from there, since title is null in the journal. Done when the journal title is clickable with a hover cue, keeps the heading styling, and a standalone page still shows plain text.
Written by the indexing model from the issue text.
Description
In the journal view, clicking a day's title should open that day as a page on its own, the same as following a [[link]] to it. Today the title is plain text and clicking it does nothing.
Behaviour
- In the journal, each day's title is a link to that day's page. Clicking it opens the page, and the titlebar shows "← Journal" to go back, as it does for any page opened from a link.
- On a page opened on its own, the title stays plain text. A link there would go to the page already showing.
- The title should look clickable on hover, but stay a heading. It should not take on the accent colour of a link in the text.
What already exists
app/src/renderer/project/PageView/PageView.tsxrenders the title three ways. A cut under "Linked references" and a zoomed page both render it as<a className="wikilink" href="#<title>">. The normal case, which is what the journal shows, renders it as a plain<h2>.app/src/renderer/project/ProjectView.tsxalready follows anya.wikilink[href]click withpages.go({ page }). So rendering the journal's<h2>title as that same link is most of the change, with no new IPC.PageViewdoes not know whether it is in the journal or showing one page alone.ProjectViewdoes:titleis null in the journal. It can pass that down as a prop.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 31m
- Merged PRs (30d)
- 25
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from shovon/pbnotes
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Website for Pb NotesOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Delete a pageOpenenhancement
Difficulty 5/5 Over a week Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gnosis/gnosis_vpn#661 ·
Maintainers usually reply within 1 day
-
content-freshness: staleOwnedContent doc comments still say 'complete receipt' (follow-up to #7912)Opentriage:bug-verified
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
fix: reject sourceStorage/packagedStorage bucket that differs from the stack default (fail loud)Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Eyevinn/open-videocore#1300 ·
Maintainers usually reply within 1 day
-
nextjs-tracking
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
cloudflare/vinext#4390 ·
Maintainers usually reply within 1 day
-
kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
kubernetes-sigs/headlamp#8175 ·
Maintainers usually reply within 2 days