Remove 'zoom' attribute from any VisualModels that still have it

Open Beginner friendly
  • Is something wrong?
#187 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
computer-graphics

Research direction

Start by locating the VisualModel definitions and the zoom member, then read VoronoiVisual to see how it uses zoom during rendering. Search the other VisualModels for remaining zoom attributes and trace their use of transform or view matrices. The work is done when no VisualModel carries a zoom attribute and rendering uses the matrix path instead, with existing plotting and visualization tests still passing.

Written by the indexing model from the issue text.

Description

Prefer a transform matrix or viewmatrix.

VoronoiVisual is one case.

Dominant language
C++
Stars
66
Forks
13
Avg merge
13h 58m
Merged PRs (30d)
12

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sebsjames/mathplot

All issues in sebsjames/mathplot

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.