feat: Go extractor records no read of a composite-literal element value
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start in internal/indexer/goextract/goextract.go: the composite_literal case of captureExprRead (~1184) delegates to captureCompositeElements (~1249) and captureElementWrites (~1277), which only record field writes. Add a read for each element value (bare identifier, selector, call, nested literal) across slice, struct, map-key and map-value positions, and fix the stale comment at 956-962. Check behavior with the p.go repro and internal/indexer/bindings_test.go, then run task golden:regen and task corpora:measure and update the hugo goldens, corpora/observations.json, docs/CORPUS-MEASUREMENT.md, matrix.go:101 and docs/LANGUAGE-CAPABILITY-MATRIX.md:126.
Written by the indexing model from the issue text.
Description
What exists today?
internal/indexer/goextract/goextract.go records no read for a value that a composite literal element holds.
How does it behave now?
Repro in a file p.go:
package p
type T struct{ F int }
func f(v, a, b int) {
_ = T{F: v}
_ = []int{a, b}
_ = map[int]int{a: b}
}
f gets a write reference to F and an instantiates reference to T. f gets no read reference to v, a or b. The map key a gets no read either.
The cause is in the composite-literal path:
collectReferencesAndInstantiatessends acomposite_literaltocaptureExprReadand stops (goextract.go:986).- The
composite_literalcase ofcaptureExprRead(goextract.go:1184-1188) callsrecordInstantiateandcaptureCompositeElements. It never reads an element value. captureCompositeElements(goextract.go:1249-1272) records only anAccessWritemember reference for a keyed element.captureElementWrites(goextract.go:1277-1299) acts only onliteral_value,composite_literalandunary_expression. A bare identifier, selector or call records nothing.captureExprReadhas noliteral_elementcase.
The block comment at goextract.go:956-962 says element values are read positions. The code does not do that, so the comment is stale.
The gap is recorded as a known limit in internal/indexer/capability/matrix.go:101 and docs/LANGUAGE-CAPABILITY-MATRIX.md:126. #342 left it open because recording the reads changes explore ranking and a hugo golden.
Effect: codegraph node and callers-style read queries miss these reads. The planned Accessed by ← line in #335 misses them too.
How should it behave?
A composite-literal element value records a read reference from the enclosing function. This covers bare identifiers, selectors, calls and nested literals, in slice elements, struct fields, map keys and map values. A keyed struct element still records its write to the field.
For the repro, f gets read references to v, a and b. It keeps the write to F and the instantiates reference to T.
The same change must fix the stale comment at goextract.go:956-962.
The fix changes these artifacts, and the PR must update each one:
- Hugo goldens under
testdata/golden/corpus/hugo/(go-explore*.json, probablygo-node*.json), checked byTestGoldensMatchLiveEngineOutput. corpora/observations.jsonanddocs/CORPUS-MEASUREMENT.md.- The matrix entries at
matrix.go:101anddocs/LANGUAGE-CAPABILITY-MATRIX.md:126.
Whether TestExtract_Instantiates, TestExtract_InstantiatesUnnamedTypeNoRef or TestGoFieldWritesWithholdCalls (internal/indexer/bindings_test.go) needs changes is open until the fix runs.
Run task golden:regen and task corpora:measure in the same PR.
What kind of improvement?
Correctness in an edge case
Would this change existing behavior?
Yes. Each composite-literal element adds a read reference, so these outputs change:
codegraph nodeand callers-style read queries list more readers.- Explore ranking changes, which regenerates the hugo goldens.
The output shapes stay the same. Only the set of read entries changes.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked that the current behavior is not a deliberate decision in
openspec/specs/
🤖 Generated with Claude Code
- Dominant language
- Go
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 16m
- Merged PRs (30d)
- 107
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from seanb4t/codegraph-go
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
seanb4t/codegraph-go#380 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#379 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
seanb4t/codegraph-go#362 ·
Maintainers usually reply within 1 day
-
area:query bug priority:low spec-needed
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
seanb4t/codegraph-go#355 ·
Maintainers usually reply within 1 day
All issues in seanb4t/codegraph-go
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day