feat: Go extractor records no read of a composite-literal element value
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start in internal/indexer/goextract/goextract.go: the composite_literal case of captureExprRead (~1184) delegates to captureCompositeElements (~1249) and captureElementWrites (~1277), which only record field writes. Add a read for each element value (bare identifier, selector, call, nested literal) across slice, struct, map-key and map-value positions, and fix the stale comment at 956-962. Check behavior with the p.go repro and internal/indexer/bindings_test.go, then run task golden:regen and task corpora:measure and update the hugo goldens, corpora/observations.json, docs/CORPUS-MEASUREMENT.md, matrix.go:101 and docs/LANGUAGE-CAPABILITY-MATRIX.md:126.
由索引模型根据 Issue 内容生成。
描述
What exists today?
internal/indexer/goextract/goextract.go records no read for a value that a composite literal element holds.
How does it behave now?
Repro in a file p.go:
package p
type T struct{ F int }
func f(v, a, b int) {
_ = T{F: v}
_ = []int{a, b}
_ = map[int]int{a: b}
}
f gets a write reference to F and an instantiates reference to T. f gets no read reference to v, a or b. The map key a gets no read either.
The cause is in the composite-literal path:
collectReferencesAndInstantiatessends acomposite_literaltocaptureExprReadand stops (goextract.go:986).- The
composite_literalcase ofcaptureExprRead(goextract.go:1184-1188) callsrecordInstantiateandcaptureCompositeElements. It never reads an element value. captureCompositeElements(goextract.go:1249-1272) records only anAccessWritemember reference for a keyed element.captureElementWrites(goextract.go:1277-1299) acts only onliteral_value,composite_literalandunary_expression. A bare identifier, selector or call records nothing.captureExprReadhas noliteral_elementcase.
The block comment at goextract.go:956-962 says element values are read positions. The code does not do that, so the comment is stale.
The gap is recorded as a known limit in internal/indexer/capability/matrix.go:101 and docs/LANGUAGE-CAPABILITY-MATRIX.md:126. #342 left it open because recording the reads changes explore ranking and a hugo golden.
Effect: codegraph node and callers-style read queries miss these reads. The planned Accessed by ← line in #335 misses them too.
How should it behave?
A composite-literal element value records a read reference from the enclosing function. This covers bare identifiers, selectors, calls and nested literals, in slice elements, struct fields, map keys and map values. A keyed struct element still records its write to the field.
For the repro, f gets read references to v, a and b. It keeps the write to F and the instantiates reference to T.
The same change must fix the stale comment at goextract.go:956-962.
The fix changes these artifacts, and the PR must update each one:
- Hugo goldens under
testdata/golden/corpus/hugo/(go-explore*.json, probablygo-node*.json), checked byTestGoldensMatchLiveEngineOutput. corpora/observations.jsonanddocs/CORPUS-MEASUREMENT.md.- The matrix entries at
matrix.go:101anddocs/LANGUAGE-CAPABILITY-MATRIX.md:126.
Whether TestExtract_Instantiates, TestExtract_InstantiatesUnnamedTypeNoRef or TestGoFieldWritesWithholdCalls (internal/indexer/bindings_test.go) needs changes is open until the fix runs.
Run task golden:regen and task corpora:measure in the same PR.
What kind of improvement?
Correctness in an edge case
Would this change existing behavior?
Yes. Each composite-literal element adds a read reference, so these outputs change:
codegraph nodeand callers-style read queries list more readers.- Explore ranking changes, which regenerates the hugo goldens.
The output shapes stay the same. Only the set of read entries changes.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked that the current behavior is not a deliberate decision in
openspec/specs/
🤖 Generated with Claude Code
- 主要语言
- Go
- 星标
- 0
- 派生
- 0
- 平均合并
- 7 小时 42 分钟
- 30 天内合并 PR
- 111
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
seanb4t/codegraph-go 的其他 Issue
-
chore needs-triage
难度 1/5 1 小时以内 新手友好度 88/100
seanb4t/codegraph-go#380 ·
维护者通常 1 天内回复
-
chore needs-triage
难度 2/5 1-3 小时 新手友好度 82/100
seanb4t/codegraph-go#379 ·
维护者通常 1 天内回复
-
area:query chore needs-triage spec-needed
难度 2/5 1-3 小时 新手友好度 74/100
seanb4t/codegraph-go#377 ·
维护者通常 1 天内回复
-
chore needs-triage
难度 1/5 1-3 小时 新手友好度 84/100
seanb4t/codegraph-go#362 ·
维护者通常 1 天内回复
-
area:query bug needs-triage
难度 2/5 1-3 小时 新手友好度 80/100
seanb4t/codegraph-go#355 ·
维护者通常 1 天内回复
查看 seanb4t/codegraph-go 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
automated documentation maintenance
难度 1/5 1-3 小时 新手友好度 75/100
github/gh-aw-mcpg#16717 ·
维护者通常 1 天内回复
-
Docs: Recording rules pages don't say what happens to a recorded metric when its rule is deleted未关闭internal
难度 1/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 74/100
jesseduffield/lazygit#6229 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
prometheus/prometheus#20482 ·
维护者通常 2 天内回复