fix: a snapshot of a shared store handle is not tied to the user that took it

Open
#283 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
go
Domain
databases

Research direction

Start in internal/graphstore/shared.go, where one Pebble handle is shared per store path, then read Snapshot() and Close() in internal/graphstore/pebble_store.go around lines 331, 354 and 489. Settle the open choice between per-user reader counting and the rule in design.md D1 that each user closes its readers first, using review note inv-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md. Done means a two-user test through graphstore.Open where the non-final Close reports its own open snapshot.

Written by the indexing model from the issue text.

Description

bug priority:low
What happens

graphstore shares one Pebble handle for each store path in a process (internal/graphstore/shared.go). Snapshot() returns a pebbleReader that holds only its Pebble snapshot (internal/graphstore/pebble_store.go:331). The reader has no link to the store that created it.

pebbleReader.Close releases its snapshot (pebble_store.go:489). pebbleStore.Close returns nil while other users still hold the handle (pebble_store.go:354). A snapshot that one user leaks stays open until the last user closes the handle. Pebble then reports the leak on that last user's Close, not on the user that leaked it.

Review note inv-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md records this. Every production caller closes its snapshot first today, so this is a latent defect, not a present one.

What you expected instead

The leak error must land on the user that took the snapshot. A Close that is not the last one must report its own open readers.

Whether the store counts open readers per user, or D1 in design.md states that each user closes its readers first, is open. Either choice needs a test with two users, where one closes with an open snapshot.

Steps to reproduce

Found by code reading. No test in the tree covers this case.

  1. Open one store path twice in one process with graphstore.Open. Name the handles first and second.
  2. Call first.Snapshot() and keep the reader open.
  3. Call first.Close(). It returns nil.
  4. Call second.Close(). Pebble reports the open snapshot here.
Version

Not from a release build. Found on main at c6788f5d, after #282 merged.

Platform

Darwin 27.2.0 (macOS). The architecture was not recorded.

How did you install it?

Other

Found in review of #282, not from an install.

Languages in the affected repository

Not applicable. The defect is in the Go store, not in language extraction.

Before submitting
  • I searched existing issues and this is not a duplicate
  • I checked the capability matrix and this is not a documented limitation
  • This is not a security vulnerability

Related: #282 added the shared handle, and review note inv-1 names this defect.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ATb3AjCdy2v381oRkeyVrV

Dominant language
Go
Stars
0
Forks
0
Avg merge
5h 16m
Merged PRs (30d)
107

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from seanb4t/codegraph-go

All issues in seanb4t/codegraph-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.