fix: a snapshot of a shared store handle is not tied to the user that took it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start in internal/graphstore/shared.go, where one Pebble handle is shared per store path, then read Snapshot() and Close() in internal/graphstore/pebble_store.go around lines 331, 354 and 489. Settle the open choice between per-user reader counting and the rule in design.md D1 that each user closes its readers first, using review note inv-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md. Done means a two-user test through graphstore.Open where the non-final Close reports its own open snapshot.
Written by the indexing model from the issue text.
Description
What happens
graphstore shares one Pebble handle for each store path in a process (internal/graphstore/shared.go). Snapshot() returns a pebbleReader that holds only its Pebble snapshot (internal/graphstore/pebble_store.go:331). The reader has no link to the store that created it.
pebbleReader.Close releases its snapshot (pebble_store.go:489). pebbleStore.Close returns nil while other users still hold the handle (pebble_store.go:354). A snapshot that one user leaks stays open until the last user closes the handle. Pebble then reports the leak on that last user's Close, not on the user that leaked it.
Review note inv-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md records this. Every production caller closes its snapshot first today, so this is a latent defect, not a present one.
What you expected instead
The leak error must land on the user that took the snapshot. A Close that is not the last one must report its own open readers.
Whether the store counts open readers per user, or D1 in design.md states that each user closes its readers first, is open. Either choice needs a test with two users, where one closes with an open snapshot.
Steps to reproduce
Found by code reading. No test in the tree covers this case.
- Open one store path twice in one process with
graphstore.Open. Name the handlesfirstandsecond. - Call
first.Snapshot()and keep the reader open. - Call
first.Close(). It returns nil. - Call
second.Close(). Pebble reports the open snapshot here.
Version
Not from a release build. Found on main at c6788f5d, after #282 merged.
Platform
Darwin 27.2.0 (macOS). The architecture was not recorded.
How did you install it?
Other
Found in review of #282, not from an install.
Languages in the affected repository
Not applicable. The defect is in the Go store, not in language extraction.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked the capability matrix and this is not a documented limitation
- This is not a security vulnerability
Related: #282 added the shared handle, and review note inv-1 names this defect.
🤖 Generated with Claude Code
- Dominant language
- Go
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 16m
- Merged PRs (30d)
- 107
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from seanb4t/codegraph-go
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
seanb4t/codegraph-go#380 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#379 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
seanb4t/codegraph-go#362 ·
Maintainers usually reply within 1 day
-
area:query bug priority:low spec-needed
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
seanb4t/codegraph-go#355 ·
Maintainers usually reply within 1 day
All issues in seanb4t/codegraph-go
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day