fix: a snapshot of a shared store handle is not tied to the user that took it
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start in internal/graphstore/shared.go, where one Pebble handle is shared per store path, then read Snapshot() and Close() in internal/graphstore/pebble_store.go around lines 331, 354 and 489. Settle the open choice between per-user reader counting and the rule in design.md D1 that each user closes its readers first, using review note inv-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md. Done means a two-user test through graphstore.Open where the non-final Close reports its own open snapshot.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
graphstore shares one Pebble handle for each store path in a process (internal/graphstore/shared.go). Snapshot() returns a pebbleReader that holds only its Pebble snapshot (internal/graphstore/pebble_store.go:331). The reader has no link to the store that created it.
pebbleReader.Close releases its snapshot (pebble_store.go:489). pebbleStore.Close returns nil while other users still hold the handle (pebble_store.go:354). A snapshot that one user leaks stays open until the last user closes the handle. Pebble then reports the leak on that last user's Close, not on the user that leaked it.
Review note inv-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md records this. Every production caller closes its snapshot first today, so this is a latent defect, not a present one.
What you expected instead
The leak error must land on the user that took the snapshot. A Close that is not the last one must report its own open readers.
Whether the store counts open readers per user, or D1 in design.md states that each user closes its readers first, is open. Either choice needs a test with two users, where one closes with an open snapshot.
Steps to reproduce
Found by code reading. No test in the tree covers this case.
- Open one store path twice in one process with
graphstore.Open. Name the handlesfirstandsecond. - Call
first.Snapshot()and keep the reader open. - Call
first.Close(). It returns nil. - Call
second.Close(). Pebble reports the open snapshot here.
Version
Not from a release build. Found on main at c6788f5d, after #282 merged.
Platform
Darwin 27.2.0 (macOS). The architecture was not recorded.
How did you install it?
Other
Found in review of #282, not from an install.
Languages in the affected repository
Not applicable. The defect is in the Go store, not in language extraction.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked the capability matrix and this is not a documented limitation
- This is not a security vulnerability
Related: #282 added the shared handle, and review note inv-1 names this defect.
🤖 Generated with Claude Code
- Lingua principale
- Go
- Stelle
- 0
- Fork
- 0
- Merge medio
- 7h 42m
- PR unite (30g)
- 111
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di seanb4t/codegraph-go
-
chore needs-triage
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
seanb4t/codegraph-go#380 ·
I maintainer di solito rispondono entro 1 giorno
-
chore needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
seanb4t/codegraph-go#379 ·
I maintainer di solito rispondono entro 1 giorno
-
area:query chore needs-triage spec-needed
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
seanb4t/codegraph-go#377 ·
I maintainer di solito rispondono entro 1 giorno
-
chore needs-triage
Difficoltà 1/5 1-3 ore Idoneità per principianti 84/100
seanb4t/codegraph-go#362 ·
I maintainer di solito rispondono entro 1 giorno
-
area:query bug needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
seanb4t/codegraph-go#355 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di seanb4t/codegraph-go
Issue simili
-
Add iterate GmbH domains to a dedicated list and include it in company and developer categoriesAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
v2fly/domain-list-community#4307 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
I maintainer di solito rispondono entro 1 giorno
-
notify: voice_queue rows are deleted only at startup, so a hub that stays up grows it without boundAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
mattabate/life-distributable#232 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 83/100
I maintainer di solito rispondono entro 1 giorno