chore(test): semantic acceptance cases have no second reader

Open
#266 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
50/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
go, json, markdown
Domain
testing-qa

Research direction

Start with step 3 of "Acceptance review" in testdata/semantic/README.md, then open the 10 case.json files under testdata/semantic/heldout/ and compare each fact with the matching src/ directory. Read the case before looking at any CodeGraph output. Where an expectation is wrong, fix it, increase expectationRevision, and explain the change in the pull request. Done when all 10 cases have been reviewed and any corrections are recorded.

Written by the indexing model from the issue text.

Description

area:ci chore priority:low
What kind of chore?

Test infrastructure

What needs doing?

Have a second reviewer read the 10 acceptance cases under testdata/semantic/heldout/ against their src/ directories. The review covers the facts in each case.json, not the CodeGraph result.

Step 3 of "Acceptance review" in testdata/semantic/README.md requires this review for each new acceptance revision. The reviewer must not look at CodeGraph output for a case before reading it. If an expectation is wrong, change it, increase expectationRevision and record the reason in the pull request.

Why now?

#264 added these cases and merged, and the same author wrote all of them. The pull request listed this as a known limit. The gate reports these cases as acceptance evidence, so an error in an expectation can pass in the gate with nothing to show it.

Does this touch anything load-bearing?
  • The release pipeline (release.yml, .goreleaser.yaml, signing)
  • The upgrade identity (internal/upgrade/verify.go)
  • The perf baseline (tools/bench/baseline.json)
  • The graph schema / meta-key layout
  • None of these
Before submitting
  • I searched existing issues and this is not a duplicate
Dominant language
Go
Stars
0
Forks
0
Avg merge
5h 16m
Merged PRs (30d)
107

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from seanb4t/codegraph-go

All issues in seanb4t/codegraph-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.