chore(test): semantic acceptance cases have no second reader

Aperta
#266 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
50/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go, json, markdown
Ambito
testing-qa

Direzione di ricerca

Start with step 3 of "Acceptance review" in testdata/semantic/README.md, then open the 10 case.json files under testdata/semantic/heldout/ and compare each fact with the matching src/ directory. Read the case before looking at any CodeGraph output. Where an expectation is wrong, fix it, increase expectationRevision, and explain the change in the pull request. Done when all 10 cases have been reviewed and any corrections are recorded.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:ci chore priority:low
What kind of chore?

Test infrastructure

What needs doing?

Have a second reviewer read the 10 acceptance cases under testdata/semantic/heldout/ against their src/ directories. The review covers the facts in each case.json, not the CodeGraph result.

Step 3 of "Acceptance review" in testdata/semantic/README.md requires this review for each new acceptance revision. The reviewer must not look at CodeGraph output for a case before reading it. If an expectation is wrong, change it, increase expectationRevision and record the reason in the pull request.

Why now?

#264 added these cases and merged, and the same author wrote all of them. The pull request listed this as a known limit. The gate reports these cases as acceptance evidence, so an error in an expectation can pass in the gate with nothing to show it.

Does this touch anything load-bearing?
  • The release pipeline (release.yml, .goreleaser.yaml, signing)
  • The upgrade identity (internal/upgrade/verify.go)
  • The perf baseline (tools/bench/baseline.json)
  • The graph schema / meta-key layout
  • None of these
Before submitting
  • I searched existing issues and this is not a duplicate
Lingua principale
Go
Stelle
0
Fork
0
Merge medio
7h 42m
PR unite (30g)
111

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di seanb4t/codegraph-go

Tutte le issue di seanb4t/codegraph-go

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.