fix: release-pr leaves a stale changie/release PR open when the unreleased fragments drop to zero

Open
#109 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
github-actions, go, yaml

Research direction

Start with .github/workflows/release-pr.yml lines 35-37 and 85-98 to see how the batch step output gates the release PR step, then look at the release:batch target in Taskfile.yml near line 999. The new close target needs to be a task target, as TestWorkflowRunBodiesInvokeTask in internal/upgrade/taskfile_shape_test.go requires. Done means an open changie/release PR is closed with an explanatory comment when there are no fragments, and the shape tests and docs/RELEASE-PROCEDURES.md §4 are updated.

Written by the indexing model from the issue text.

Description

area:ci bug priority:low
What happens

When .changes/unreleased/ has no fragments, task release:batch exits 0 with no version output, and the "Open or update the release PR" step is skipped. Nothing closes an already-open changie/release PR. Sequence: run R1 updates the PR; the maintainer merges the previous version, or the fragments are reverted (push P2); run R2 sees zero fragments and does nothing. The PR that R1 left keeps its mergeable-looking title chore(main): release vX.Y.Z. concurrency uses cancel-in-progress: false, so R1 still finishes after P2.

What you expected instead

In the zero-fragment path, any open changie/release PR is closed (with the App token) with a comment saying why.

Steps to reproduce

Open a release PR, then remove the fragments on main by revert. release-pr runs and leaves the PR open.

Version

main at d384473e

Platform

GitHub Actions

Evidence
  • .github/workflows/release-pr.yml:85-98 (if: steps.batch.outputs.version != ''), :35-37
  • Taskfile.yml:999 (release:batch)
  • internal/upgrade/taskfile_shape_test.go:1381 (TestWorkflowRunBodiesInvokeTask: the close must be a task target)
Acceptance criteria
  • A new Taskfile target closes an open changie/release PR. The workflow calls it only when version is empty.
  • The shape tests cover the new step and token.
  • docs/RELEASE-PROCEDURES.md §4 mentions the behavior.

Source (GSD planning files, archived at d384473e): .planning/todos/pending/2026-10-17-close-a-stale-changie-release-pr-in-the-zero-fragment-path-w.md


🤖 Generated with Claude Code

https://claude.ai/code/session_01UNqdnC3q6U362BvyfxuKCF

Dominant language
Go
Stars
0
Forks
0
Avg merge
5h 16m
Merged PRs (30d)
107

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from seanb4t/codegraph-go

All issues in seanb4t/codegraph-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.