fix: release-pr leaves a stale changie/release PR open when the unreleased fragments drop to zero

Abierto
#109 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github-actions, go, yaml

Línea de trabajo

Start with .github/workflows/release-pr.yml lines 35-37 and 85-98 to see how the batch step output gates the release PR step, then look at the release:batch target in Taskfile.yml near line 999. The new close target needs to be a task target, as TestWorkflowRunBodiesInvokeTask in internal/upgrade/taskfile_shape_test.go requires. Done means an open changie/release PR is closed with an explanatory comment when there are no fragments, and the shape tests and docs/RELEASE-PROCEDURES.md §4 are updated.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:ci bug priority:low
What happens

When .changes/unreleased/ has no fragments, task release:batch exits 0 with no version output, and the "Open or update the release PR" step is skipped. Nothing closes an already-open changie/release PR. Sequence: run R1 updates the PR; the maintainer merges the previous version, or the fragments are reverted (push P2); run R2 sees zero fragments and does nothing. The PR that R1 left keeps its mergeable-looking title chore(main): release vX.Y.Z. concurrency uses cancel-in-progress: false, so R1 still finishes after P2.

What you expected instead

In the zero-fragment path, any open changie/release PR is closed (with the App token) with a comment saying why.

Steps to reproduce

Open a release PR, then remove the fragments on main by revert. release-pr runs and leaves the PR open.

Version

main at d384473e

Platform

GitHub Actions

Evidence
  • .github/workflows/release-pr.yml:85-98 (if: steps.batch.outputs.version != ''), :35-37
  • Taskfile.yml:999 (release:batch)
  • internal/upgrade/taskfile_shape_test.go:1381 (TestWorkflowRunBodiesInvokeTask: the close must be a task target)
Acceptance criteria
  • A new Taskfile target closes an open changie/release PR. The workflow calls it only when version is empty.
  • The shape tests cover the new step and token.
  • docs/RELEASE-PROCEDURES.md §4 mentions the behavior.

Source (GSD planning files, archived at d384473e): .planning/todos/pending/2026-10-17-close-a-stale-changie-release-pr-in-the-zero-fragment-path-w.md


🤖 Generated with Claude Code

https://claude.ai/code/session_01UNqdnC3q6U362BvyfxuKCF

Lenguaje dominante
Go
Estrellas
0
Forks
0
Merge medio
5 h 16 min
PR fusionados (30 d)
107

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de seanb4t/codegraph-go

Todos los issues de seanb4t/codegraph-go

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.