Tests fail when the Mac isn't set to English
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start by inspecting the Xcode scheme’s test action and the two failing tests: MouseButtonShortcutTests.testButtonsAreNumberedFromTheLeftButton and WindowActionShortcutViewTests.testStoredMouseButtonIsShownByName. Configure the test action to use English and the US region, then run the scheme’s tests on a Mac set to a different language; done means both tests pass there.
Written by the indexing model from the issue text.
Description
- This is a new bug that hasn't been documented in a closed issue or in the Readme.
macOS version: 27.0.1
Rectangle version: main at 0698b04 (after v2.0.4)
Logs if applicable (In Rectangle menu, hold option, "View Logging..."): not applicable, this is a test failure
What happens
On a Mac whose language isn't English, xcodebuild test (or Product > Test in Xcode) fails 2 tests, 4 checks:
MouseButtonShortcutTests.testButtonsAreNumberedFromTheLeftButtonWindowActionShortcutViewTests.testStoredMouseButtonIsShownByName
They compare against English text ("Middle Button", "Button 4", "⌥⌘ Button 5"), but the test host runs in the Mac's language and gets the translation instead.
On main this already happens on a Mac set to Spanish, Brazilian Portuguese, Hindi, Ukrainian or Chinese, which translate those strings. #1957 adds Italian, and on an Italian Mac the tests get "Pulsante centrale" and "Pulsante 4".
Expected
The tests pass whatever language the Mac is set to.
Fix
Run the scheme's test action in English (language = "en", region = "US"). A pull request follows.
- Dominant language
- Swift
- Stars
- 30.2k
- Forks
- 1k
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rxhanson/Rectangle
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 1/100
Maintainers usually reply within 3 days
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 3 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
rxhanson/Rectangle#1943 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
rxhanson/Rectangle#1929 · 4 comments ·
Maintainers usually reply within 3 days
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
rxhanson/Rectangle#1922 · 5 comments ·
Maintainers usually reply within 3 days
All issues in rxhanson/Rectangle
Similar issues
-
feat: 앱 정보에 개인정보처리방침과 고객지원 연결Possibly taken @xrpjwk8 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
DeveloperAcademy-POSTECH/2026-C6-A13-Hear-I-am#120 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jaywcjlove/quick-rss#448 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
VictorKildahl/cra#205 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: Intermittent failure in PathUtilsTests.testNewDirectoryIsExcludedAndExistingChoiceIsKeptOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apple/container#2474 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
AttilaTheFun/visor#244 ·
Maintainers usually reply within 1 day