Mac proof: carets blink and the inspector's thread lands in different places from run to run

Open Beginner friendly
  • Is something wrong?
#244 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
swift
Domain
testing

Research direction

Start with tools/ci/proof_mac.sh and proof.yml, then inspect how the mac-new-session, mac-question, and mac-inspector screenshots are captured. Disable the focused field’s caret for the shot and make the inspector thread settle at its end after the inspector is shown. Done means repeated Mac proof runs produce matching screenshots for these screens.

Written by the indexing model from the issue text.

Description

The Mac part of the proof (proof.yml, tools/ci/proof_mac.sh, since #241) isn't yet the same pixels from run to run, so a release proof can show changes no code made. Two sources, found by comparing two runs of nearly the same tree: run 42140814167 on #241's branch and run 42142991174 on #242's.

  1. A blinking caret. mac-new-session and mac-question differ by 32 pixels, a 2 by 16 rectangle where a text field's caret is: (369, 563) and (804, 432). The iPhone's screens don't, all 22 unchanged.
  2. The inspector's thread. On mac-inspector, the chat lands at a different scroll position once the inspector narrows it: 81,127 pixels between the two runs. Two launches of one build already differ by 104,939 (scratch run 42139594585, attempts 1 and 2), so this is not #242's change. The thread re-wraps for the narrower column, and where it settles is down to timing.

To fix

  • Hide the caret on the screenshot fixture, as ~/Developer/AGENTS.md asks ("no caret blinking in the shot"). Or take the screen with no field focused.
  • On the inspector screen, scroll the thread to its end again once the inspector is in, before the picture. Or open the inspector before the rows settle, so they lay out once at the narrower width.

🤖 Generated with Claude Code

Dominant language
Swift
Stars
1
Forks
0
Avg merge
7h 43m
Merged PRs (30d)
131

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AttilaTheFun/visor

All issues in AttilaTheFun/visor

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.