Respect direct manipulation of `X509_STORE`

Open
  • Is something wrong?
#17 1 comment 0 reactions 1 assignee View on GitHub

@ctz is already working on this.

Since May 13, 2024.

Assessment

This issue has not been assessed yet.

Description

enhancement

At the moment certificate verification takes into account trusted certificates added via SSL_CTX_load_verify_file (and similar). However, it does not look at anything added by directly manipulating the X509_STORE returned from SSL_CTX_get_cert_store.

At minimum, we could extract certs and CRLs from that object each time and feed that to our verifier, at maximum we could entirely use the verifier in libcrypto (at the cost of more memory-unsafe code in the TCB).

Dominant language
Rust
Stars
87
Forks
13
Avg merge
47m
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rustls/rustls-openssl-compat

All issues in rustls/rustls-openssl-compat

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.