bug: pressing right arrow on the edit java arguments adds the U+001D unicode

Open Beginner friendly
  • Is something wrong?
#8,332 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
desktop, frontend

Research direction

Start from the Java arguments text field in the instance settings under Java and memory settings, and find the keydown/input handler that appends typed characters. Reproduce by placing the cursor at the end of the field and holding the right arrow; the handler is letting a control character (U+001D) through. Done when the arrow key is ignored at the field boundary and no character is inserted, verified manually in the app.

Written by the indexing model from the issue text.

Description

app
Please confirm the following.
  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?

0.23.3

What operating systems are you seeing the problem on?

MacOS

Describe the bug

pressing right arrow key while the cursor is at the end of this box produces a unicode

image
Steps to reproduce
  1. go to an instance settings
  2. click on java and memory settings
  3. hold right arrow when typing in the java arguments box when the cursor is at the very end
Expected behavior

no unicode to appear and nothing to happen

Additional context

low priority

Dominant language
Rust
Stars
2.5k
Forks
663
Avg merge
2d 11h
Merged PRs (30d)
122

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from modrinth/code

All issues in modrinth/code

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.