Don't wait for PR approval when PR author is a maintainer
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Read ci-bench-runner/src/job/bench_pr.rs, especially the existing allowed account association check at lines 29-36, then trace the event processing for a new PR. The change is complete when PRs authored by an organization maintainer no longer require approval or a comment before benchmarking, while other PRs retain the current behavior.
Written by the indexing model from the issue text.
Description
An idea from djc in discord:
would be nice if the benchmarking bot knew it doesn't need to wait for approval on PRs where the author is an org maintainer
I think this would be a fairly small lift: we already have the code in place to check when a PR is approved that the approver has an allowed account association. Likely we just need to adjust the event processing for a new PR to skip requiring an approval or a comment if the author has such an association.
- Dominant language
- Rust
- Stars
- 13
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rustls/rustls-bench-app
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
rustls/rustls-bench-app#34 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
rustls/rustls-bench-app#33 · 2 comments ·
All issues in rustls/rustls-bench-app
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Eyevinn/open-live-ingest#36 · 1 comment ·
Maintainers usually reply within 1 day
-
app
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug bug jury peripheral:i2s
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
esp-rs/esp-hal#6828 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
ライブラリを追加Openpriority middle
Difficulty 1/5 Under an hour Newbie friendliness 62/100
KATO-Hiro/AtCoderClans#13015 ·
Maintainers usually reply within 1 day