Prune login_activities older than 13 months (stored IPs and typed emails are kept forever)

Open Beginner friendly
#7,296 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@KoushikSagarr is already working on this.

Since Nov 8, 2026.

  • #7357 by @KoushikSagarr — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
rails, ruby
Domain
backend, database

Research direction

Start with app/models/metrics_report.rb (active_users_by_type, ALLOWED_RANGES) to confirm the 12-month window, then look at lib/tasks/expire_case_contact_drafts.rake for the rake task style. Add app/services/prune_login_activities_service.rb using in_batches.delete_all on LoginActivity with a configurable window of at least 13 months. Done when the specs in spec/models/metrics_report_spec.rb and the new service spec pass and the rake task prints the deleted count.

Written by the indexing model from the issue text.

Description

Difficulty: Easy Good First Issue Help Wanted

Problem

login_activities (written by the authtrail gem on every Devise sign-in attempt) is never pruned. It's the second-largest table in production (~8 MB, behind only case_contacts), and every row holds personal data:

  • identity: the email that was typed, including failed attempts, which can be mistyped emails or other people's addresses
  • ip, user_agent, referrer
  • user_id, success, failure_reason, created_at

(Geocoding is off in config/initializers/authtrail.rb, so city/region/country/latitude/longitude are empty.)

Keeping this forever adds privacy risk without benefit. The only reader in the app is the all-CASA-admin Metrics page: "Monthly active users", MetricsReport#active_users_by_type in app/models/metrics_report.rb. Its widest range is 12 months (ALLOWED_RANGES = [3, 6, 12]).

Related: #7263 (PII in logs and Bugsnag).

Proposal

Keep 13 months of login activity (the 12-month metrics window plus the partial current month) and delete older rows daily.

  • A service, e.g. app/services/prune_login_activities_service.rb, that deletes LoginActivity.where(created_at: ...13.months.ago) with in_batches.delete_all so a large first run doesn't hold one long transaction. It returns the count deleted. Make the window configurable (LOGIN_ACTIVITY_RETENTION_MONTHS, default 13, minimum 13) so it can never cut into the metrics window.
  • A rake task rake prune_login_activities that calls it and prints the count. Follow the style of lib/tasks/expire_case_contact_drafts.rake.
  • Specs:
    • deletes rows older than the window
    • keeps rows inside it
    • refuses a window under 13 months
    • the Metrics page's 12-month monthly-active-users numbers are unchanged after pruning (spec/models/metrics_report_spec.rb)
  • Note in the PR description that a maintainer must add the task to Heroku Scheduler (daily).

Out of scope

Changing what authtrail records, e.g. not storing identity for failed attempts. That's worth a separate discussion under #7263.

Difficulty: beginner. One service, one rake task, specs.

Dominant language
Ruby
Stars
384
Forks
558
Avg merge
1d 7h
Merged PRs (30d)
63

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rubyforgood/casa

All issues in rubyforgood/casa

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.