Prune login_activities older than 13 months (stored IPs and typed emails are kept forever)
维护者通常 1 天内回复
评估
调研方向
从 app/models/metrics_report.rb(active_users_by_type、ALLOWED_RANGES)开始,确认 12 个月的时间窗口,然后查看 lib/tasks/expire_case_contact_drafts.rake 了解 rake 任务的写法。新增 app/services/prune_login_activities_service.rb,对 LoginActivity 使用 in_batches.delete_all,时间窗口可配置且至少为 13 个月。完成标准是 spec/models/metrics_report_spec.rb 中的规范和新的服务规范全部通过,并且 rake 任务会输出被删除的记录数。
由索引模型根据 Issue 内容生成。
描述
Problem
login_activities (written by the authtrail gem on every Devise sign-in attempt) is never pruned. It's the second-largest table in production (~8 MB, behind only case_contacts), and every row holds personal data:
identity: the email that was typed, including failed attempts, which can be mistyped emails or other people's addressesip,user_agent,referreruser_id,success,failure_reason,created_at
(Geocoding is off in config/initializers/authtrail.rb, so city/region/country/latitude/longitude are empty.)
Keeping this forever adds privacy risk without benefit. The only reader in the app is the all-CASA-admin Metrics page: "Monthly active users", MetricsReport#active_users_by_type in app/models/metrics_report.rb. Its widest range is 12 months (ALLOWED_RANGES = [3, 6, 12]).
Related: #7263 (PII in logs and Bugsnag).
Proposal
Keep 13 months of login activity (the 12-month metrics window plus the partial current month) and delete older rows daily.
- A service, e.g.
app/services/prune_login_activities_service.rb, that deletesLoginActivity.where(created_at: ...13.months.ago)within_batches.delete_allso a large first run doesn't hold one long transaction. It returns the count deleted. Make the window configurable (LOGIN_ACTIVITY_RETENTION_MONTHS, default 13, minimum 13) so it can never cut into the metrics window. - A rake task
rake prune_login_activitiesthat calls it and prints the count. Follow the style oflib/tasks/expire_case_contact_drafts.rake. - Specs:
- deletes rows older than the window
- keeps rows inside it
- refuses a window under 13 months
- the Metrics page's 12-month monthly-active-users numbers are unchanged after pruning (
spec/models/metrics_report_spec.rb)
- Note in the PR description that a maintainer must add the task to Heroku Scheduler (daily).
Out of scope
Changing what authtrail records, e.g. not storing identity for failed attempts. That's worth a separate discussion under #7263.
Difficulty: beginner. One service, one rake task, specs.
- 主要语言
- Ruby
- 星标
- 384
- 派生
- 558
- 平均合并
- 1 天 7 小时
- 30 天内合并 PR
- 63
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
rubyforgood/casa 的其他 Issue
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
难度 2/5 1-3 小时 新手友好度 82/100
rubyforgood/casa#7404 ·
维护者通常 1 天内回复
-
Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
难度 2/5 1-3 小时 新手友好度 76/100
rubyforgood/casa#7402 ·
维护者通常 1 天内回复
-
Remove the bin/bundle binstub (Heroku warns it can break Bundler on deploy)可能已有人在做 @Akash-Dhanwate 于 8 天前认领。 未关闭dependencies Difficulty: Easy Good First Issue
难度 1/5 1 小时以内 新手友好度 82/100
rubyforgood/casa#7325 · 2 条评论 ·
维护者通常 1 天内回复
-
Reports page: move export-button disable/re-enable into a Stimulus controller可能重新可做 @Akash-Dhanwate 于 9 天前认领,目前没有进行中的 PR。 未关闭Difficulty: Easy Good First Issue Help Wanted javascript
难度 2/5 1-3 小时 新手友好度 72/100
rubyforgood/casa#7311 · 2 条评论 ·
维护者通常 1 天内回复
-
New case: use Stimulus for the "I don't know the court date yet" toggle可能重新可做 @Aryankn29 于 9 天前认领,目前没有进行中的 PR。 未关闭Difficulty: Easy Good First Issue Help Wanted javascript
难度 2/5 1-3 小时 新手友好度 78/100
rubyforgood/casa#7310 · 1 条评论 ·
维护者通常 1 天内回复
相似的 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 66/100
internetee/registry#2984 ·
维护者通常 6 天内回复
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configured可能已有人在做 @mimosa 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
riscv/riscv-unified-db#2829 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
docker-library/ruby#534 ·
-
难度 2/5 1-3 小时 新手友好度 68/100