Upgrade rubocop-capybara to 3.x (#7256) and decide the future of .rubocop.yml

Open
#7,276 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
ruby
Domain
tooling

Research direction

Start by checking PR #7256's CI after its rebase, then read the rubocop-capybara changelog and inspect .rubocop.yml. Run bundle exec rubocop spec/system to verify the plugin loads and identify any needed config changes; compare any failures with the reported Selenium errors. Done means reporting whether the upgrade works and recommending whether the unused RuboCop configuration and plugins should be kept, wired into CI, or removed.

Written by the indexing model from the issue text.

Description

dependencies Difficulty: Easy Help Wanted 🧹 Linting

Problem

Dependabot's #7256 bumps rubocop-capybara from 2.23 to 3.1 (a major version). Its last CI run failed ruby_lint and rspec. The lint failure was an unrelated issue that's since been fixed on main, and the PR has been asked to rebase, so the first step is to see what's actually still failing.

Context

  • rubocop-capybara is in the Gemfile's development/test group and listed under plugins: in .rubocop.yml.
  • CI does not run it. ruby_lint runs bundle exec standardrb, which uses .standard.yml, not .rubocop.yml. So the bump only matters to people who run bundle exec rubocop locally.

Tasks

  • Check #7256's CI after the rebase. If it's green, check locally that bundle exec rubocop spec/system still loads the plugin under 3.x (read the changelog for renamed or removed cops and config keys) and fix .rubocop.yml if needed
  • If it's still red, find out whether the failures are caused by the bump or just flaky (system spec Selenium errors)
  • Bigger question, for a separate PR: should .rubocop.yml and its plugins stay at all, given CI only runs Standard? Either wire them into bin/lint/CI or remove the unused gems. Comment with a recommendation.

Difficulty: easy to intermediate.

Dominant language
Ruby
Stars
384
Forks
558
Avg merge
1d 7h
Merged PRs (30d)
63

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rubyforgood/casa

All issues in rubyforgood/casa

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.