Upgrade rubocop-capybara to 3.x (#7256) and decide the future of .rubocop.yml

Ouverte
#7,276 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
52/100
Type d'issue
Refactorisation
Clarté
Plutôt claire
Activité
Active
Stack technique
ruby
Domaine
tooling

Piste de recherche

Start by checking PR #7256's CI after its rebase, then read the rubocop-capybara changelog and inspect .rubocop.yml. Run bundle exec rubocop spec/system to verify the plugin loads and identify any needed config changes; compare any failures with the reported Selenium errors. Done means reporting whether the upgrade works and recommending whether the unused RuboCop configuration and plugins should be kept, wired into CI, or removed.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

dependencies Difficulty: Easy Help Wanted 🧹 Linting

Problem

Dependabot's #7256 bumps rubocop-capybara from 2.23 to 3.1 (a major version). Its last CI run failed ruby_lint and rspec. The lint failure was an unrelated issue that's since been fixed on main, and the PR has been asked to rebase, so the first step is to see what's actually still failing.

Context

  • rubocop-capybara is in the Gemfile's development/test group and listed under plugins: in .rubocop.yml.
  • CI does not run it. ruby_lint runs bundle exec standardrb, which uses .standard.yml, not .rubocop.yml. So the bump only matters to people who run bundle exec rubocop locally.

Tasks

  • Check #7256's CI after the rebase. If it's green, check locally that bundle exec rubocop spec/system still loads the plugin under 3.x (read the changelog for renamed or removed cops and config keys) and fix .rubocop.yml if needed
  • If it's still red, find out whether the failures are caused by the bump or just flaky (system spec Selenium errors)
  • Bigger question, for a separate PR: should .rubocop.yml and its plugins stay at all, given CI only runs Standard? Either wire them into bin/lint/CI or remove the unused gems. Comment with a recommendation.

Difficulty: easy to intermediate.

Langage dominant
Ruby
Étoiles
384
Forks
558
Merge moyen
1 j 7 h
PR mergées (30 j)
63

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de rubyforgood/casa

Toutes les issues de rubyforgood/casa

Issues similaires

Plus d'issues Ruby

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.