Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

cpplint checks fail for services and actions with buffers in the response/result

Open
  • Is something wrong?
#264 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
56/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
c
Domain
build-system, testing-qa

Research direction

Start with the generated rosidl_generator_py file build/.../rosidl_generator_py/srv/_get_buffer_s.c and the cpplint_rosidl_generated_py build/include_order failure. Compare the service/action generation described in #263 with the stdint.h injection from #250, including response/result/feedback versus request/goal handling. Done means the affected generated-code cpplint checks pass without introducing failures in the other cases.

Written by the indexing model from the issue text.

Description

bug
Generated by Generative AI

No

Operating System:

any

ROS version or commit hash:

rolling, lyrical

RMW implementation (if applicable):

No response

RMW Configuration (if applicable):

No response

Client library (if applicable):

No response

'ros2 doctor --report' output

No response

Steps to reproduce issue

See #263

Expected behavior

Tests pass

Actual behavior

Tests fail

- rosidl_generator_py.cpplint_rosidl_generated_py build/include_order [4] (/ws/build/rosidl_generator_py/rosidl_generator_py/rosidl_generator_py/srv/_get_buffer_s.c:83)
  <<< failure message
    Found C system header after other header. Should be: _get_buffer_s.h, c system, c++ system, other.
  >>>
Additional information

#250 injects <stdint.h> into the headers, which might appear in the generated code after non-C headers, if the code is for services and actions, which have buffer type in their response/result/feedback, but not in the response/goal.

There are two simple fixes:

  1. silence build/include_order in the cpplint checks
  2. always add <stdint.h>

A more complicated fix would add stdint.h as in the request/goal part, if the parts use buffers.

Dominant language
EmberScript
Stars
26
Forks
69
Avg merge
1d 18h
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ros2/rosidl_python

All issues in ros2/rosidl_python

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.