Outdated genType output and a mislabelled CodeTab in `typescript-integration.mdx`
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1424 by @fhammerschmidt — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 66/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- documentation
Research direction
Start with the TypeScript tab around lines 113-114 of typescript-integration.mdx and replace the old genType import with the 12.2.0 form the issue quotes. Then open the CodeTab at line 93 and the candidate component apps/docs/src/components/Markdown.res near line 322 to confirm why the JS block loses its label; the issue says the fallback label was not checked. Done means the TypeScript snippet matches the current genType output and every CodeTab block shows its intended label.
Written by the indexing model from the issue text.
Description
The TypeScript tab at lines 113-114 shows an older genType form (import * as MyCompBS__Es6Import from "./MyComp.res"; const MyCompBS: any = …); genType from 12.2.0 emits import * as MyCompJS from './MyComp.res.js';. The CodeTab at line 93 has two labels and three code blocks, so the JS block renders without its intended label (apps/docs/src/components/Markdown.res:322; candidate, fallback label not checked).
Line numbers refer to master at ff3eac6e.
- Dominant language
- MDX
- Stars
- 1.9k
- Forks
- 260
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 33
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rescript-lang/rescript-lang.org
-
`yarn vitest:update` (documented) throws locally; local Cypress scripts target an unserved portOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rescript-lang/rescript-lang.org#1415 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rescript-lang/rescript-lang.org#1411 ·
Maintainers usually reply within 1 day
-
Unused public assetsPossibly taken @fhammerschmidt claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rescript-lang/rescript-lang.org#1402 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
rescript-lang/rescript-lang.org#1433 ·
Maintainers usually reply within 1 day
-
Semantic drift analysis: resultsPossibly taken @fhammerschmidt claimed this 1 day ago. Open
rescript-lang/rescript-lang.org#1421 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in rescript-lang/rescript-lang.org
Similar issues
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 4 days
-
Перевод устарел
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
area:connector bug
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
environment: OPENCODE_API_KEY is described as a Console service account key, but a Go subscription key worksPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tester-army/e2e#1015 ·
Maintainers usually reply within 1 day