Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

BindInteraction does not follow ViewModel when the view inherits it from another assembly (e.g. ReactiveUserControl<T>)

Closed
#170 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

A pull request for this has already been merged.

  • #180 by @ChrisPulman — merged

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp

Research direction

Start from BindingEmitterHelpers.ResolveViewModelObservation and TypeDetectionExtractor.ExtractProperties / CollectMembersThroughOwnBases, which stop walking bases at the assembly boundary so an inherited ViewModel is missed. Compare with FindViewModelProperty, which already walks bases. Reproduce with the IViewFor plus referenced-assembly base case in the issue; done when BindInteraction (and likely Bind/OneWayBind/BindCommand) follows view.ViewModel across that boundary as in ReactiveUI 24.

Written by the indexing model from the issue text.

Description

bug
Prerequisites
  • I have searched this repository's open and closed issues for duplicates.
  • I am using the latest stable release.
What happens

On a view that derives from Avalonia's ReactiveUserControl<T>, BindInteraction registers the handler on the view model the view has at the moment of the call, and never moves it:

  • If the view has no view model yet (normal inside WhenActivated, before the host sets the DataContext), no handler is ever registered. Every Handle call later throws UnhandledInteractionException.
  • If the view model is replaced later (a view whose DataContext follows a selection, for example), the handler stays on the first view model. The new one has no handler.

The same call on a view that declares its own ViewModel property follows view.ViewModel correctly. The difference is only where the ViewModel property is declared: if the view inherits it from a base class in another assembly (as every ReactiveUserControl<T> subclass does), the binding stops following the view.

How we ran into it. Our app is a PDF viewer built on Avalonia, with one tab per open document. The main window hosts a single document view, a ReactiveUserControl<PdfFileViewModel>, whose DataContext is bound to the selected tab, so switching tabs swaps the view model under a view that stays loaded. In WhenActivated that view binds 17 interactions with BindInteraction: zoom in/out, page up/down, scroll to page, fit to width, the save dialog and so on. A search panel works the same way for "focus the search box" on Ctrl+F.

The view activates once, when the window loads. At that point usually no document is open yet, so ViewModel is null. On ReactiveUI 24 this worked: each handler moved to whichever document was selected. After upgrading to ReactiveUI 25 none of the documents had handlers, so the zoom buttons, page navigation, bookmarks and Ctrl+F focus all failed with UnhandledInteractionException. When the app restored a document at startup, only that one document worked, and its interactions acted on whichever document was on screen. Nothing warned at build time, and our tests stayed green because each test selects its document before the window finishes loading.

What you expected instead

The handler follows view.ViewModel, as it does in ReactiveUI 24 and as it already does here for a view that declares ViewModel itself:

  • bound while ViewModel is null → handled once a view model is assigned
  • ViewModel replaced → the new view model's interaction is handled, the old one's is not
Minimal reproduction
using Avalonia;
using Avalonia.Headless;
using ReactiveUI.Avalonia;
using ReactiveUI.Binding;

AppBuilder.Configure<Application>()
    .UseHeadless(new AvaloniaHeadlessPlatformOptions())
    .UseReactiveUI(static _ => { })
    .SetupWithoutStarting();

var view = new View();
using var binding = view.BindInteraction(view.ViewModel, vm => vm.Ask, Answer);   // ViewModel is still null here

var first = new ViewModel();
view.ViewModel = first;
Console.WriteLine(await IsHandled(first));    // False - expected True

var second = new ViewModel();
view.ViewModel = second;
Console.WriteLine(await IsHandled(second));   // False - expected True

static Task Answer(IInteractionContext<string, bool> context)
{
    context.SetOutput(true);
    return Task.CompletedTask;
}

static async Task<bool> IsHandled(ViewModel vm)
{
    try {
        await vm.Ask.Handle("question");
        return true;
    } catch (UnhandledInteractionException<string, bool>) {
        return false;
    }
}

public sealed class ViewModel
{
    public Interaction<string, bool> Ask { get; } = new();
}

public sealed class View : ReactiveUserControl<ViewModel>
{
}

Packages: Avalonia 12.1.3, Avalonia.Headless 12.1.3, ReactiveUI.Avalonia 12.1.6.

Without Avalonia: the same failure reproduces with a plain IViewFor<T> + INotifyPropertyChanged view, as long as ViewModel is inherited from a base class in a referenced assembly. Three views, identical except where ViewModel is declared:

View ViewModel declared Result
on the view itself view follows the view model ✔
inherited from a base in the same assembly same assembly follows the view model ✔
inherited from an identical base in a referenced class library other assembly does not follow ✘
Steps to reproduce
  1. Create a console app with the packages above and the code above.
  2. Run it.
  3. Both lines print False; expected True twice.
Exception and stack trace
When the interaction is raised from app code:


ReactiveUI.Binding.UnhandledInteractionException`2[System.String,System.Boolean]: Failed to find a registration for an Interaction.
   at ReactiveUI.Binding.Interaction`2.Handle(TInput input)
Package and version

ReactiveUI.Binding 8.8.0 and 9.1.0 (via ReactiveUI 25.1.1 / 26.0.1 and ReactiveUI.Avalonia 12.1.5 / 12.1.6)

UI framework

Avalonia

Operating system

Windows

Target framework

net10.0

Device and OS version

Windows 11 Pro 10.0.26200, x64

IDE

Visual Studio 2026 18.0

Did this work in an earlier version?

ReactiveUI 24.2.0

Workaround

Observe the interaction from the view instead of calling BindInteraction, e.g. this.WhenAnyValue(x => x.ViewModel) → select the interaction → register the handler on each new value, disposing the previous registration.

Additional information

Where it seems to come from, in case it saves time (same in v8.8.0 and v9.1.0):

  • BindingEmitterHelpers.ResolveViewModelObservation roots the binding at the view only when FindViewModelPropertyType finds a typed ViewModel in the view's detected properties. Otherwise it binds to the viewModel argument.
  • Those properties come from TypeDetectionExtractor.ExtractProperties → CollectMembersThroughOwnBases, which stops walking base classes at the assembly boundary, so an inherited ViewModel (e.g. ReactiveUserControl<T>.ViewModel) is never seen.
  • FindViewModelProperty in the same file does walk the bases, and is what the #158 field-owner path uses.

Since ResolveViewModelObservation is shared by Bind, OneWayBind and BindCommand, those view-first bindings are presumably affected on such views too. Only BindInteraction was tested.

Dominant language
C#
Stars
9
Forks
2
Avg merge
7h 7m
Merged PRs (30d)
75

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reactiveui/ReactiveUI.Binding.SourceGenerators

All issues in reactiveui/ReactiveUI.Binding.SourceGenerators

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.