could toHTML handle !important on height and width?
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start at htmltools::validateCssUnit and trace how height and width values reach the widget's inline CSS. Confirm the expected handling of !important, then verify that both dimensions accept the form described in the issue without breaking existing validation.
Written by the indexing model from the issue text.
Description
At the moment we can't instantiate a htmlwidget with inline CSS for height and width that uses the !important override. This will fail in htmltools::validateCssUnit.
This would come in handy to override framework assumptions about how to size our widgets. An example of this is {flexdashboard} which imposes height = 100% !important https://github.com/rstudio/flexdashboard/issues/351. This has created a problem for me with a htmlwidget that is a set of controls, not a visualisation.
{flexdashboard} should probably not be doing this, but allowing !important to be used on the widget's inline CSS would allow us to easily skirt this issue wherever it occurs.
- Dominant language
- R
- Stars
- 801
- Forks
- 202
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ramnathv/htmlwidgets
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ramnathv/htmlwidgets#307 · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
ramnathv/htmlwidgets#495 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ramnathv/htmlwidgets#492 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
ramnathv/htmlwidgets#489 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
ramnathv/htmlwidgets#488 · 1 comment ·
All issues in ramnathv/htmlwidgets
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tidymodels/censored#414 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
waldronlab/bugphyzz#256 ·
-
dbRemoveTable() fails on SQLite with 'near "TRUNCATE": syntax error' and leaves the table in placePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OHDSI/DatabaseConnector#348 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100