Need to be able to send secure session cookie for localhost
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- ruby
- Domain
- authentication, backend
Research direction
Start in lib/rack/session/abstract/id.rb and inspect security_matches? to understand how secure cookies are currently limited to SSL requests. Verify the localhost behavior described in the issue while preserving the existing secure-cookie restriction for other hosts, then check the relevant session tests.
Written by the indexing model from the issue text.
Description
Right now, unless it is ssl, you can't send a secure session cookie. It is perfectly valid to do this for localhost, and very desirable for development.
In lib/rack/session/abstract/id.rb, I think it should say something like:
def security_matches?(request,options)
return true unless options[:secure]
request.ssl? || request.host == "localhost"
end
- Dominant language
- Ruby
- Stars
- 52
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rack/rack-session
-
Set-Cookie header is set in response when valid cookies are sent in headersPossibly taken @hieuk09 claimed this 431 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
rack/rack-session#52 · 5 comments · 1 reaction ·
-
Unused test codeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
rack/rack-session#51 ·
-
Make use of default key value when creating `Rack::Session::Encryptor`Possibly taken @themichaelyang claimed this 327 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
rack/rack-session#35 · 1 comment · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
rack/rack-session#29 ·
All issues in rack/rack-session
Similar issues
-
bug: "Conversation information" accordion renders blank with 0px height when conversation has no attributesPossibly taken @gihovani claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days
-
`hanami generate repository` would be a nice alias for `hanami generate repo`Possibly taken @sandbergja claimed this today. Openbug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
hanami/hanami-cli#455 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
sclorg/s2i-ruby-container#660 · 1 comment ·
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 86/100
bridgetownrb/bridgetown#1130 ·