Render the `core:version` banner natively and deprecate `povils/figlet`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 74/100
Research direction
Start with src/Console/Commands/VersionCommand.php and trace how it currently calls povils/figlet. Check the starter project's public/assets/shared/fonts/figlet/ files and the existing changelog format. Done means the core renderer handles all four shipped fonts, php qt core:version matches the previous slant banner for QUANTUM PHP 3.2.0, and the changelog records the deprecation.
Written by the indexing model from the issue text.
Description
Summary
Add a small FIGlet renderer to the core and use it for the banner of php qt core:version, instead of povils/figlet. Keep povils/figlet in composer.json, deprecated, and remove it in a later release.
Why
povils/figlet has had no release since 2016. Its last version, 1.0.0, requires symfony/console ~3.0, so it cannot be installed next to the Symfony Console the core uses, and the core is stuck on 0.1.0 (found while working on #687). The only maintained-looking alternative, laminas/laminas-text, is abandoned. The core uses the package for one thing: rendering QUANTUM PHP <version> with the slant font, which the starter project already ships in public/assets/shared/fonts/figlet/.
Proposed change
- A renderer class in the Console package that reads a FIGlet
.flffont file and renders a string, with the three methodsVersionCommanduses:setFontDir(),setFont()andrender(). VersionCommanduses it.povils/figletstays incomposer.jsonand gets a Deprecated changelog entry: the core no longer uses it, and it will be removed in a later release. Applications that callPovils\Figlet\Figletthemselves should require the package in their owncomposer.json.
Acceptance criteria
php qt core:versionprints the same banner as before: a test compares the native output forQUANTUM PHP 3.2.0with theslantfont against the output ofpovils/figlet0.1.0.- the renderer handles the four fonts the starter project ships (
big,slant,small,standard) - the changelog records the deprecation
Notes
src/Console/Commands/VersionCommand.php- the font files are in quantum-php/project,
public/assets/shared/fonts/figlet/
- Dominant language
- PHP
- Stars
- 43
- Forks
- 22
- Avg merge
- 54m
- Merged PRs (30d)
- 57
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from quantum-php/framework
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
quantum-php/framework#692 ·
Maintainers usually reply within 1 day
-
routing testing
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
quantum-php/framework#547 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 72/100
quantum-php/framework#694 ·
Maintainers usually reply within 1 day
-
refactoring tech debt
Difficulty 5/5 Over a week Newbie friendliness 20/100
quantum-php/framework#693 ·
Maintainers usually reply within 1 day
-
install:debugbar reads the package folder from the working directory and uses the default storage adapterPossibly taken @armanist claimed this today. Openbug console debugbar good first issue
quantum-php/framework#691 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in quantum-php/framework
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
dependencies enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
novalo-dev/Prestashop-MCP-Server#329 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug origin:interactive status:available
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day