Render the `core:version` banner natively and deprecate `povils/figlet`

Aberta
#688 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
74/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
php
Domínio
backend, cli

Direção de pesquisa

Start with src/Console/Commands/VersionCommand.php and trace how it currently calls povils/figlet. Check the starter project's public/assets/shared/fonts/figlet/ files and the existing changelog format. Done means the core renderer handles all four shipped fonts, php qt core:version matches the previous slant banner for QUANTUM PHP 3.2.0, and the changelog records the deprecation.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

console enhancement

Summary

Add a small FIGlet renderer to the core and use it for the banner of php qt core:version, instead of povils/figlet. Keep povils/figlet in composer.json, deprecated, and remove it in a later release.

Why

povils/figlet has had no release since 2016. Its last version, 1.0.0, requires symfony/console ~3.0, so it cannot be installed next to the Symfony Console the core uses, and the core is stuck on 0.1.0 (found while working on #687). The only maintained-looking alternative, laminas/laminas-text, is abandoned. The core uses the package for one thing: rendering QUANTUM PHP <version> with the slant font, which the starter project already ships in public/assets/shared/fonts/figlet/.

Proposed change

  • A renderer class in the Console package that reads a FIGlet .flf font file and renders a string, with the three methods VersionCommand uses: setFontDir(), setFont() and render().
  • VersionCommand uses it.
  • povils/figlet stays in composer.json and gets a Deprecated changelog entry: the core no longer uses it, and it will be removed in a later release. Applications that call Povils\Figlet\Figlet themselves should require the package in their own composer.json.

Acceptance criteria

  • php qt core:version prints the same banner as before: a test compares the native output for QUANTUM PHP 3.2.0 with the slant font against the output of povils/figlet 0.1.0.
  • the renderer handles the four fonts the starter project ships (big, slant, small, standard)
  • the changelog records the deprecation

Notes

  • src/Console/Commands/VersionCommand.php
  • the font files are in quantum-php/project, public/assets/shared/fonts/figlet/
Linguagem predominante
PHP
Estrelas
43
Forks
22
Merge médio
54min
PRs com merge (30d)
57

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de quantum-php/framework

Todas as issues de quantum-php/framework

Issues semelhantes

Mais issues de PHP

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.