Rebase the vendored biscuit fork onto biscuit-rust 7.0, and pin Ed25519

Open
#367 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
rust

Research direction

Read the vendored fork in third_party against upstream biscuit-rust 7.0.0-alpha.3, starting with block_datalog, the biscuit-parser bump, and the load path exercised by hostile.rs. Run the token round-trip and hostile-input tests, then follow any from_with_limits adoption to the error substrings hostile.rs asserts; properties.rs:329 shows where unsafe-protobuf-access is needed. Done means the fork builds, existing wicket tokens still load, and structure::check plus the hostile/error tests pass.

Written by the indexing model from the issue text.

Description

enhancement

From reading biscuit-rust (2026-11-15). The vendored fork (third_party, 6.0.0-fork.0) is at upstream main aa5a672, two days before 7.0.0-alpha.1, so most of 7.0's breaks are already in. What's left, up to alpha.3:

  • blocks are parsed once, and a block referring to a symbol defined later is rejected;
  • legacy third-party blocks no longer load;
  • DeserializationLimits/BlockLimits are new;
  • the protobuf types sit behind unsafe-protobuf-access (needed for properties.rs:329).

The wire format is unchanged, so tokens wicket mints still load.

Rebase work: block_datalog needs about 15 lines rewritten, and biscuit-parser goes to 0.3.0-alpha.1. If load adopts from_with_limits, map the error substrings hostile.rs asserts.

What it buys: pinning Ed25519 through the limits; structure::check stays. 7.0 still has no parser for a lone third-party (grant) block.

Dominant language
Rust
Stars
0
Forks
0
Avg merge
1h 43m
Merged PRs (30d)
190

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from public/wicket

All issues in public/wicket

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.