clippy -D warnings is red on main: MIN_LABEL_PX in painted.rs is never used after PR #2095
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 86/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- build-system
Research direction
Open crates/ui/src/egui_app/painted.rs: MIN_LABEL_PX is defined around line 115 and only mentioned in the comment at line 98, since the ribbon caption now uses the theme's caption size (#2063). Read that comment and the caption code, then either delete the constant or wire it back in, keeping the comment accurate. Done means cargo clippy -p camcraft-ui --all-targets -- -D warnings passes on main.
Written by the indexing model from the issue text.
Description
What happens: on upstream/main at 780b0a25a (the merge of PR #2095, #2066), cargo clippy -p camcraft-ui --all-targets -- -D warnings fails:
error: constant `MIN_LABEL_PX` is never used
--> crates/ui/src/egui_app/painted.rs:115:11
The constant is now referenced only in a comment (painted.rs:98); the ribbon caption code reads the theme's caption size instead (#2063). The batch gate runs clippy, so it is red on main.
Expected: clippy clean on main.
Found while gating #163 (not touched by that change).
Done means: cargo clippy -p camcraft-ui --all-targets -- -D warnings passes on main (remove the constant or use it, and update the comment at painted.rs:98).
- Dominant language
- Rust
- Stars
- 8
- Forks
- 11
- Avg merge
- 6h 45m
- Merged PRs (30d)
- 905
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NeoTech/Camcraft
-
area:ui effort:low enhancement P7 source:agent
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
NeoTech/Camcraft#2039 · 3 comments ·
Maintainers usually reply within 1 day
-
area:sim area:turning effort:low P7 source:agent
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
NeoTech/Camcraft#1855 · 4 comments ·
Maintainers usually reply within 1 day
-
area:turning area:ui effort:low P7 source:agent
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
area:build effort:low P7 source:agent
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
post-merge.yml: the report job is skipped when the gate fails, so a red main opens no issuePossibly taken @tbrasselle claimed this today. Openarea:build bug claimed effort:low P5 source:agent
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
NeoTech/Camcraft#1611 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in NeoTech/Camcraft
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
akitaonrails/ai-memory#2314 ·
Maintainers usually reply within 1 day
-
bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nledford/Ladderback#809 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ElectronicWave/Elemental#265 ·
Maintainers usually reply within 1 day
-
bug low-priority
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dividebysandwich/rust-dos#1170 ·
Maintainers usually reply within 1 day
-
area:cli area:security bug priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day