clippy -D warnings is red on main: MIN_LABEL_PX in painted.rs is never used after PR #2095

Open Beginner friendly
#2,104 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
86/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
build-system

Research direction

Open crates/ui/src/egui_app/painted.rs: MIN_LABEL_PX is defined around line 115 and only mentioned in the comment at line 98, since the ribbon caption now uses the theme's caption size (#2063). Read that comment and the caption code, then either delete the constant or wire it back in, keeping the comment accurate. Done means cargo clippy -p camcraft-ui --all-targets -- -D warnings passes on main.

Written by the indexing model from the issue text.

Description

area:ui bug effort:low P2 source:agent

What happens: on upstream/main at 780b0a25a (the merge of PR #2095, #2066), cargo clippy -p camcraft-ui --all-targets -- -D warnings fails:

error: constant `MIN_LABEL_PX` is never used
   --> crates/ui/src/egui_app/painted.rs:115:11

The constant is now referenced only in a comment (painted.rs:98); the ribbon caption code reads the theme's caption size instead (#2063). The batch gate runs clippy, so it is red on main.

Expected: clippy clean on main.

Found while gating #163 (not touched by that change).

Done means: cargo clippy -p camcraft-ui --all-targets -- -D warnings passes on main (remove the constant or use it, and update the comment at painted.rs:98).

Dominant language
Rust
Stars
8
Forks
11
Avg merge
6h 45m
Merged PRs (30d)
905

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NeoTech/Camcraft

All issues in NeoTech/Camcraft

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.