diff: `-t --tabsize=<huge>` aborts in `do_expand_tabs`
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 65/100
Direção de pesquisa
The bug is in src/utils.rs in the do_expand_tabs function. Start by reading the function to understand how tabsize is used in capacity calculations at lines 20 and 31. Look for where tabsize is parsed from the command line to see if bounds checking is missing. Write a test that reproduces the abort with large tabsize values, then add validation to limit tabsize to a safe maximum or handle allocation failures gracefully.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
--tabsize is parsed into a usize with no upper bound and then used to size an allocation: do_expand_tabs reserves line.len() + ntabs * (tabsize - 1) bytes or every line containing a tab. A large --tabsize makes that request exceed what the allocator can serve and the process aborts with no diff: diagnostic.
$ printf '\tx\n' > a; printf 'y\n' > b
$ diff -t --tabsize=18446744073709551615 a b > /dev/null
Aborted (core dumped)
$ echo $?
134
The threshold is the allocator, not a parse guard — the request scales directly
with the flag:
$ diff -t --tabsize=1000000000 a b # 1e9 -> exit 1, diffs normally
$ diff -t --tabsize=4611686018427387904 a b # 2^62
memory allocation of 4611686018427387905 bytes failed -> exit 134
$ diff -t --tabsize=9223372036854775807 a b # isize::MAX -> exit 134
A tab in the input is required — ntabs == 0 returns early.
Root cause
src/utils.rs:
pub fn do_expand_tabs(line: &[u8], tabsize: usize) -> Vec<u8> {
let tab = b'\t';
let ntabs = line.iter().filter(|c| **c == tab).count();
if ntabs == 0 {
return line.to_vec();
}
let mut result = Vec::with_capacity(line.len() + ntabs * (tabsize - 1)); // :20
let mut offset = 0;
let mut iter = line.split(|c| *c == tab).peekable();
while let Some(chunk) = iter.next() {
...
if iter.peek().is_some() {
result.resize(result.len() + tabsize - offset % tabsize, b' '); // :31
tabsize comes straight from --tabsize and multiplies the tab count. Nothing bounds it at parse time, so the capacity is attacker-chosen and the allocation aborts.
The same function aborts at a second site, src/utils.rs:31. Once the with_capacity at :20 is survived, the per-chunk result.resize(result.len() + tabsize - offset % tabsize, b' ') requests another attacker-sized allocation. Which of the two fires depends on the --tabsize value:
# :20 — capacity overflow (tabsize = 2^63)
$ diffutils diff -t --tabsize=9223372036854775808 a b
thread 'main' panicked at library/alloc/src/raw_vec/mod.rs:...: capacity overflow
$ echo $?
134
# :31 — allocation abort (tabsize = u64::MAX)
$ printf '\tx\n' > a; printf 'y\n' > b
$ diffutils diff -t --tabsize=18446744073709551615 a b
thread 'main' panicked at library/alloc/src/raw_vec/mod.rs:28:5:
$ echo $?
134
- Linguagem predominante
- Rust
- Estrelas
- 276
- Forks
- 39
- Merge médio
- 4d 12h
- PRs com merge (30d)
- 3
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de uutils/diffutils
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 85/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
-
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 45/100
Todas as issues de uutils/diffutils
Issues semelhantes
-
bug github_actions
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
registrystack/registry-stack#1393 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
longbridge/gpui-kit#3223 ·
-
bug engine
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
rocky-data/rocky#2181 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
oasisprotocol/oasis-sdk#2523 ·
-
[indexer] [QA] Add a focused test for the new NonRetryableError / assertSocketAlive() behavior. Abertabot:ai-assisted component:indexer QA-roadmap status:untriaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
midnightntwrk/midnight-indexer#1557 ·