Fix per-namespace RBAC collisions across Argo CD instances and controllers
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Facilidade para iniciantes
- 35/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- go, kubernetes
- Domínio
- authorization, backend
Direção de pesquisa
Read argocd-operator/controllers/argocd/image_updater.go, role.go, and rolebinding.go, then trace source namespace cleanup and ApplicationSet reconciliation. Map how Image Updater and application source namespace RBAC create, reconcile, and remove overlapping resources. Done means the listed collision, upgrade, interruption, and cleanup scenarios are covered by tests while preserving active permissions and removing confirmed stale grants.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Per-namespace RBAC resources for Image Updater can collide with resources managed by another Argo CD instance or by application source namespace reconciliation. These collisions can cause controllers to overwrite each other's RBAC state or remove permissions that are still needed.
Scenarios
- Same-named Argo CD instances: Two instances in different namespaces watch the same target namespace and use the same per-namespace Role and RoleBinding names. After a failed or interrupted reconciliation, a Role can carry instance A's owner label while its RoleBinding grants access to instance B. When A prunes the namespace, it can delete the Role and remove B's manager permissions.
- Role collision with applications in any namespace: Image Updater calls
newRoleForApplicationSourceNamespaces, which is also used for application source namespace RBAC. When the scopes overlap, Image Updater and the application controller can reconcile the same Role with different rules. - RoleBinding collision with applications in any namespace: Image Updater calls
newRoleBindingForSupportNamespaces, which is also used for application source namespace RBAC. When the scopes overlap, Image Updater and the application controller can reconcile the same RoleBinding with different subjects or Role references.
Required work
Provide a general solution that isolates per-namespace RBAC by component and Argo CD instance. Consider distinct resource names that include the component and instance namespace. Alternatively, evaluate Image Updater-specific ownership marks and changes to application and ApplicationSet reconciliation, including how they avoid same-name Kubernetes object collisions.
Handle existing shared resources during upgrade. Preserve active permissions while migrating, and remove stale grants without deleting resources still needed by another instance or component.
Affected areas include argocd-operator/controllers/argocd/image_updater.go, argocd-operator/controllers/argocd/role.go, argocd-operator/controllers/argocd/rolebinding.go, and source namespace cleanup.
Acceptance criteria
- Same-named instances can reconcile and prune overlapping target namespaces without overwriting or removing each other's required RBAC.
- Image Updater and application source namespace RBAC can coexist without conflicting Role rules or RoleBinding subjects and references. Check ApplicationSet reconciliation as well.
- Cleanup preserves Roles referenced by another instance's active RoleBinding and still removes confirmed stale orphaned resources.
- Upgrade and interrupted-reconciliation paths preserve needed access and do not leave stale grants.
- Tests cover the three scenarios, overlapping scopes, upgrade, interruption, and cleanup.
Requested by @dkarpele.
PR: https://github.com/redhat-developer/gitops-operator/pull/1511
Review finding: https://github.com/redhat-developer/gitops-operator/pull/1511#discussion_r4517295806
Related review comment: https://github.com/redhat-developer/gitops-operator/pull/1511#discussion_r4509278543
- Linguagem predominante
- Go
- Estrelas
- 190
- Forks
- 367
- Merge médio
- 4d 2h
- PRs com merge (30d)
- 63
Preparar o ambiente
- Inclui um Dockerfile ou arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de redhat-developer/gitops-operator
-
Manager does not detect Route CRD that appears after startupTalvez já em andamento @atishay-kasliwal assumiu hoje. Aberta
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 48/100
redhat-developer/gitops-operator#1566 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
NamespaceManagement revocation checks labels on the wrong namespaceTalvez já em andamento @Rizwana777 assumiu há 3 dias. Abertakind/bug
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 25/100
redhat-developer/gitops-operator#1559 · 1 comentário · 1 responsável ·
Mantenedores costumam responder em até 1 dia
-
Deleting an ArgoCD instance removes RBAC belonging to same-named instancesTalvez já em andamento @Rizwana777 assumiu há 3 dias. Abertakind/bug
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 45/100
redhat-developer/gitops-operator#1558 · 1 responsável ·
Mantenedores costumam responder em até 1 dia
-
NamespaceManagement cleanup can delete RBAC in unrelated namespacesTalvez já em andamento @Rizwana777 assumiu há 3 dias. Abertakind/bug
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 22/100
redhat-developer/gitops-operator#1557 · 1 responsável ·
Mantenedores costumam responder em até 1 dia
-
ApplicationSet tokenRef strict mode changes only apply after the controller is restartedTalvez já em andamento @Gabrielandre02 assumiu há 5 dias. Aberta
redhat-developer/gitops-operator#1554 · 1 comentário · 1 responsável ·
Mantenedores costumam responder em até 1 dia
Todas as issues de redhat-developer/gitops-operator
Issues semelhantes
-
benchmark
Dificuldade 1/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 77/100
mozilla-ai/cq#601 ·
Mantenedores costumam responder em até 1 dia
-
documentation migration
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia