Fix per-namespace RBAC collisions across Argo CD instances and controllers
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- go, kubernetes
- Ambito
- authorization, backend
Direzione di ricerca
Read argocd-operator/controllers/argocd/image_updater.go, role.go, and rolebinding.go, then trace source namespace cleanup and ApplicationSet reconciliation. Map how Image Updater and application source namespace RBAC create, reconcile, and remove overlapping resources. Done means the listed collision, upgrade, interruption, and cleanup scenarios are covered by tests while preserving active permissions and removing confirmed stale grants.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Per-namespace RBAC resources for Image Updater can collide with resources managed by another Argo CD instance or by application source namespace reconciliation. These collisions can cause controllers to overwrite each other's RBAC state or remove permissions that are still needed.
Scenarios
- Same-named Argo CD instances: Two instances in different namespaces watch the same target namespace and use the same per-namespace Role and RoleBinding names. After a failed or interrupted reconciliation, a Role can carry instance A's owner label while its RoleBinding grants access to instance B. When A prunes the namespace, it can delete the Role and remove B's manager permissions.
- Role collision with applications in any namespace: Image Updater calls
newRoleForApplicationSourceNamespaces, which is also used for application source namespace RBAC. When the scopes overlap, Image Updater and the application controller can reconcile the same Role with different rules. - RoleBinding collision with applications in any namespace: Image Updater calls
newRoleBindingForSupportNamespaces, which is also used for application source namespace RBAC. When the scopes overlap, Image Updater and the application controller can reconcile the same RoleBinding with different subjects or Role references.
Required work
Provide a general solution that isolates per-namespace RBAC by component and Argo CD instance. Consider distinct resource names that include the component and instance namespace. Alternatively, evaluate Image Updater-specific ownership marks and changes to application and ApplicationSet reconciliation, including how they avoid same-name Kubernetes object collisions.
Handle existing shared resources during upgrade. Preserve active permissions while migrating, and remove stale grants without deleting resources still needed by another instance or component.
Affected areas include argocd-operator/controllers/argocd/image_updater.go, argocd-operator/controllers/argocd/role.go, argocd-operator/controllers/argocd/rolebinding.go, and source namespace cleanup.
Acceptance criteria
- Same-named instances can reconcile and prune overlapping target namespaces without overwriting or removing each other's required RBAC.
- Image Updater and application source namespace RBAC can coexist without conflicting Role rules or RoleBinding subjects and references. Check ApplicationSet reconciliation as well.
- Cleanup preserves Roles referenced by another instance's active RoleBinding and still removes confirmed stale orphaned resources.
- Upgrade and interrupted-reconciliation paths preserve needed access and do not leave stale grants.
- Tests cover the three scenarios, overlapping scopes, upgrade, interruption, and cleanup.
Requested by @dkarpele.
PR: https://github.com/redhat-developer/gitops-operator/pull/1511
Review finding: https://github.com/redhat-developer/gitops-operator/pull/1511#discussion_r4517295806
Related review comment: https://github.com/redhat-developer/gitops-operator/pull/1511#discussion_r4509278543
- Lingua principale
- Go
- Stelle
- 190
- Fork
- 367
- Merge medio
- 4g 2h
- PR unite (30g)
- 63
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di redhat-developer/gitops-operator
-
Manager does not detect Route CRD that appears after startupForse già presa @atishay-kasliwal l’ha presa oggi. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
redhat-developer/gitops-operator#1566 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
NamespaceManagement revocation checks labels on the wrong namespaceForse già presa @Rizwana777 l’ha presa 3 giorni fa. Apertakind/bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 25/100
redhat-developer/gitops-operator#1559 · 1 commento · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Deleting an ArgoCD instance removes RBAC belonging to same-named instancesForse già presa @Rizwana777 l’ha presa 3 giorni fa. Apertakind/bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 45/100
redhat-developer/gitops-operator#1558 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
NamespaceManagement cleanup can delete RBAC in unrelated namespacesForse già presa @Rizwana777 l’ha presa 3 giorni fa. Apertakind/bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 22/100
redhat-developer/gitops-operator#1557 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
ApplicationSet tokenRef strict mode changes only apply after the controller is restartedForse già presa @Gabrielandre02 l’ha presa 5 giorni fa. Aperta
redhat-developer/gitops-operator#1554 · 1 commento · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di redhat-developer/gitops-operator
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Inconsistency between golang and cue in specForse già presa Una pull request collegata a questa issue è aperta o già unita. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
security
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
Tencent/LoopForge#1087 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno