Workflows: follow-ups from the #38882 review
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Facilidade para iniciantes
- 25/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- typescript
Direção de pesquisa
Start with workflow.ts for the signal and wait follow-up, then trace the agent-step and trigger runtime paths named in the issue. The list spans signal persistence, cancellation and deadlines, linked runs, issue linking, Forge pagination, and runtime imports, so each item needs its own investigation. Done means addressing the listed follow-ups with behavior that holds across retries and restarts; the issue names no tests.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Follow-ups from CodeRabbit's full review of #38882 (durable workflows) at 9eb23b1. Each was checked against the code and holds, but needs a design change bigger than that PR's review round. The minor comments from the same review are left to be picked up with the area they touch.
Signals and waits
- Validate a signal against the wait's own codec, not only its generated JSON Schema, before it wakes the wait (
Schema.FiniteFromStringpasses{type: "string"}, then fails decode after the wait has closed).workflow.tswait and early mail. signalAllretries query the current waits again: give a broadcast an id and persist its recipient set.- Reusing a signal id with a different address or payload: deliver what the store accepted, or refuse the reuse.
Agent steps
- A stop that fails during cancellation is not retried: keep a pending stop until it gets through, across restarts.
- At a deadline, stop the restart continuation of the step's turn, not only the original turn.
- A died turn on a continued thread is retried on that same thread: starting a new thread in the original thread's project needs that project at agent start, locally and over a link.
- Linked environments: use the run a linked wait settled on (a continuation), and read it by id rather than from the 50 most recent runs.
- Issue linking runs on the deadline path: record the turn and its deadline first, link separately and bounded.
- Collect a step's reply from its own run, not the thread's whole history.
Triggers and runtime
- Forge looks read at most 100 items: page back to the previous cursor instead of advancing past unread items.
- Track the definition source the runtime evaluated, not the one read before the import.
From the cross-lab review (Claude Fable 5.2, Gemini 4 Neon, Grok 4.7)
- A child that ends while the engine starts never tells its parent: the sweep is forked before
link.currentis set (WorkflowEngine.ts), sorun/toldjournals a no-op and the parent'sinvokewaits for good. runStatus("waiting")can overwritepaused(nostatus != 'paused'guard), so a run with a failed parallel branch and an open wait may sit inwaitingwithout resuming or showing in Needs you.- The engine's BigInt SQLite setting leaks into cancels and
onEndretries started by the sweep, so their thread interrupts fail quietly. - A scheduled start that fails still stores the next due time, so that occurrence is skipped.
- A step's automatic signal ids are positional, so a retried step that signals a different list drops signals.
runs()stops at 500 without saying so.- Forge
openedtriggers compare ISO timestamps as text, which breaks across formats. invokehas no timeout;pullRequests.waittakes noheadSha, so a wait after a push can settle on the previous commit's checks.- After two corrections without a result, an agent is restarted from scratch on a new thread.
- A reload refused for cross-file problems still updates the last good version of the file.
- Later, additive: a durable
race(and cleanup of a wait a plainEffect.raceloses), a concurrency cap or lock, more forge triggers, continue-as-new, retention.
Fixed on #38882 in 4703fc6 and taken out of this list: cancel stopping the whole thread, save reporting success too early, a definitions file that never finishes loading, and history with no definitions.
🤖 Generated with Claude Code
- Linguagem predominante
- TypeScript
- Estrelas
- 24.8k
- Forks
- 6.4k
- Merge médio
- 4h 29min
- PRs com merge (30d)
- 488
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de pingdotgg/t3code
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
Mantenedores costumam responder em até 1 dia
-
needs more info
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
pingdotgg/t3code#39400 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
[Bug]: Wrapped PR titles lose bottom padding in the thread details panelTalvez já em andamento @iamdatvt94 assumiu há 1 dia. Abertabug needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 1 dia
-
bug needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 73/100
Mantenedores costumam responder em até 1 dia
Todas as issues de pingdotgg/t3code
Issues semelhantes
-
area:plugins kind:bug priority:p2 ready
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 90/100
Mantenedores costumam responder em até 1 dia
-
Escaped `*` followed by `*` (`\**`) never matchesTalvez já em andamento @bardrop assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 71/100
editorconfig/editorconfig-core-js#172 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
vega/vega-webgpu#40 ·
-
Adjust break point sizingAbertatype: bug 🐛
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 63/100
puckeditor/puck#1929 ·
Mantenedores costumam responder em até 1 dia
-
compression() compresses every response at Brotli quality 11Talvez já em andamento @staylor assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 1 dia