Workflows: follow-ups from the #38882 review
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
Línea de trabajo
Start with workflow.ts for the signal and wait follow-up, then trace the agent-step and trigger runtime paths named in the issue. The list spans signal persistence, cancellation and deadlines, linked runs, issue linking, Forge pagination, and runtime imports, so each item needs its own investigation. Done means addressing the listed follow-ups with behavior that holds across retries and restarts; the issue names no tests.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Follow-ups from CodeRabbit's full review of #38882 (durable workflows) at 9eb23b1. Each was checked against the code and holds, but needs a design change bigger than that PR's review round. The minor comments from the same review are left to be picked up with the area they touch.
Signals and waits
- Validate a signal against the wait's own codec, not only its generated JSON Schema, before it wakes the wait (
Schema.FiniteFromStringpasses{type: "string"}, then fails decode after the wait has closed).workflow.tswait and early mail. signalAllretries query the current waits again: give a broadcast an id and persist its recipient set.- Reusing a signal id with a different address or payload: deliver what the store accepted, or refuse the reuse.
Agent steps
- A stop that fails during cancellation is not retried: keep a pending stop until it gets through, across restarts.
- At a deadline, stop the restart continuation of the step's turn, not only the original turn.
- A died turn on a continued thread is retried on that same thread: starting a new thread in the original thread's project needs that project at agent start, locally and over a link.
- Linked environments: use the run a linked wait settled on (a continuation), and read it by id rather than from the 50 most recent runs.
- Issue linking runs on the deadline path: record the turn and its deadline first, link separately and bounded.
- Collect a step's reply from its own run, not the thread's whole history.
Triggers and runtime
- Forge looks read at most 100 items: page back to the previous cursor instead of advancing past unread items.
- Track the definition source the runtime evaluated, not the one read before the import.
From the cross-lab review (Claude Fable 5.2, Gemini 4 Neon, Grok 4.7)
- A child that ends while the engine starts never tells its parent: the sweep is forked before
link.currentis set (WorkflowEngine.ts), sorun/toldjournals a no-op and the parent'sinvokewaits for good. runStatus("waiting")can overwritepaused(nostatus != 'paused'guard), so a run with a failed parallel branch and an open wait may sit inwaitingwithout resuming or showing in Needs you.- The engine's BigInt SQLite setting leaks into cancels and
onEndretries started by the sweep, so their thread interrupts fail quietly. - A scheduled start that fails still stores the next due time, so that occurrence is skipped.
- A step's automatic signal ids are positional, so a retried step that signals a different list drops signals.
runs()stops at 500 without saying so.- Forge
openedtriggers compare ISO timestamps as text, which breaks across formats. invokehas no timeout;pullRequests.waittakes noheadSha, so a wait after a push can settle on the previous commit's checks.- After two corrections without a result, an agent is restarted from scratch on a new thread.
- A reload refused for cross-file problems still updates the last good version of the file.
- Later, additive: a durable
race(and cleanup of a wait a plainEffect.raceloses), a concurrency cap or lock, more forge triggers, continue-as-new, retention.
Fixed on #38882 in 4703fc6 and taken out of this list: cancel stopping the whole thread, save reporting success too early, a definitions file that never finishes loading, and history with no definitions.
🤖 Generated with Claude Code
- Lenguaje dominante
- TypeScript
- Estrellas
- 24.8k
- Forks
- 6.4k
- Merge medio
- 4 h 29 min
- PR fusionados (30 d)
- 488
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de pingdotgg/t3code
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
needs more info
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
pingdotgg/t3code#39400 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
[Bug]: Wrapped PR titles lose bottom padding in the thread details panelPosiblemente ocupada @iamdatvt94 la tomó hace 1 día. Abiertobug needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
bug needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 73/100
Los mantenedores suelen responder en 1 día
Todos los issues de pingdotgg/t3code
Issues similares
-
area:plugins kind:bug priority:p2 ready
Dificultad 2/5 1-3 horas Aptitud para principiantes 90/100
Los mantenedores suelen responder en 1 día
-
Escaped `*` followed by `*` (`\**`) never matchesPosiblemente ocupada @bardrop la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 71/100
editorconfig/editorconfig-core-js#172 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
vega/vega-webgpu#40 ·
-
Adjust break point sizingAbiertotype: bug 🐛
Dificultad 2/5 1-3 horas Aptitud para principiantes 63/100
puckeditor/puck#1929 ·
Los mantenedores suelen responder en 1 día
-
compression() compresses every response at Brotli quality 11Posiblemente ocupada @staylor la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día