[Bug]: macOS Touch Bar shows the secret typed into the request card as QuickType suggestions after Save

Aberta
  • Algo errado?
#35,147 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
57/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
macos, react, typescript
Domínio
desktop, security

Direção de pesquisa

Start with apps/web and inspect SecretRequestCard.tsx, especially how the focused password field is handled when Save is pressed and when the request succeeds. Reproduce on macOS with a Touch Bar using the listed steps, then check whether the value remains protected until it is cleared. Done means saving a secret no longer exposes it as QuickType suggestions or learned text.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/web

Steps to reproduce
  1. On macOS with a Touch Bar, have an agent call request_secret (no secret source selected, so the card shows the masked field).
  2. Type a throwaway value, e.g. touchbartest. The Touch Bar shows nothing while typing.
  3. Press Save securely.
Expected behavior

The typed value is never exposed outside the masked field. No QuickType candidates for it on the Touch Bar, and macOS does not learn it as a word.

Actual behavior

Right after Save, the Touch Bar shows QuickType suggestions containing the secret: "touchbartest" and Touchbartest. The value is saved correctly. It is only exposed in the moment after Save, never while typing.

macOS only offers QuickType candidates for non-secure text input, so Secure Input appears to be dropped while the value is still in the field. macOS may also add the value to its learned words.

Suspected cause (not verified): SecretRequestCard.tsx sets disabled={submitting} on the focused type="password" input on submit. The value is only cleared after the request succeeds. Disabling the focused password field may end Secure Input while the text is still there. Keeping the field enabled (e.g. readOnly) during submit, or clearing it before disabling, might avoid this.

Possibly related, opposite direction: #22449.

Impact

Major degradation or frequent failure

Version or commit

0.1.10-nightly.20261112.4564

Environment

macOS desktop app (Nightly), MacBook with Touch Bar

Screenshots

Touch Bar right after pressing Save.

image
Workaround

None, apart from typing secrets on a Mac without a Touch Bar. It is unclear whether QuickType still learns the word there.

Linguagem predominante
TypeScript
Estrelas
24.8k
Forks
6.4k
Merge médio
4h 16min
PRs com merge (30d)
352

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de pingdotgg/t3code

Todas as issues de pingdotgg/t3code

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.